[llvm] 1bf7ed2 - [CAS] OnDiskGraphDB - fix MSVC "not all control paths return a value" warnings. NFC. (#164369)

[via llvm-commits]

Author: Simon Pilgrim
Date: 2025-10-21T08:02:13Z
New Revision: 1bf7ed27c1929152d876f9965895fd87ec8ccee4

URL: https://github.com/llvm/llvm-project/commit/1bf7ed27c1929152d876f9965895fd87ec8ccee4
DIFF: https://github.com/llvm/llvm-project/commit/1bf7ed27c1929152d876f9965895fd87ec8ccee4.diff

LOG: [CAS] OnDiskGraphDB - fix MSVC "not all control paths return a value" warnings. NFC. (#164369)

Added: 
    

Modified: 
    llvm/include/llvm/CAS/OnDiskGraphDB.h
    llvm/lib/CAS/OnDiskGraphDB.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/CAS/OnDiskGraphDB.h b/llvm/include/llvm/CAS/OnDiskGraphDB.h
index 83017a6a54fee..5f0ee0e131c0f 100644
--- a/llvm/include/llvm/CAS/OnDiskGraphDB.h
+++ b/llvm/include/llvm/CAS/OnDiskGraphDB.h
@@ -380,6 +380,7 @@ class OnDiskGraphDB {
     case ObjectPresence::OnlyInUpstreamDB:
       return true;
     }
+    llvm_unreachable("Unknown ObjectPresence enum");
   }
 
   /// When \p load is called for a node that doesn't exist, this function tries

diff  --git a/llvm/lib/CAS/OnDiskGraphDB.cpp b/llvm/lib/CAS/OnDiskGraphDB.cpp
index 72bb98c4bf65d..64cbe9dc8e159 100644
--- a/llvm/lib/CAS/OnDiskGraphDB.cpp
+++ b/llvm/lib/CAS/OnDiskGraphDB.cpp
@@ -836,6 +836,7 @@ uint64_t DataRecordHandle::getDataSize() const {
   case DataSizeFlags::Uses8B:
     return support::endian::read64le(DataSizePtr);
   }
+  llvm_unreachable("Unknown DataSizeFlags enum");
 }
 
 void DataRecordHandle::skipDataSize(LayoutFlags LF, int64_t &RelOffset) const {
@@ -863,6 +864,7 @@ uint32_t DataRecordHandle::getNumRefs() const {
   case NumRefsFlags::Uses8B:
     return support::endian::read64le(NumRefsPtr);
   }
+  llvm_unreachable("Unknown NumRefsFlags enum");
 }
 
 void DataRecordHandle::skipNumRefs(LayoutFlags LF, int64_t &RelOffset) const {
@@ -1270,6 +1272,7 @@ Expected<bool> OnDiskGraphDB::isMaterialized(ObjectID Ref) {
       return FaultInResult.takeError();
     return true;
   }
+  llvm_unreachable("Unknown ObjectPresence enum");
 }
 
 Expected<OnDiskGraphDB::ObjectPresence>