[compiler-rt] Remove non-standard use of `std::exception` in `compiler-rt/test/asan/TestCases/Windows/basic_exception_handling.cpp` (PR #164137)

Thurston Dang via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 18 19:46:06 PDT 2025


thurstond wrote:

Thanks for the fix-forward!

Btw, some quirks of LLVM:
- 'You are allowed to commit patches without approval which you think are obvious. This is clearly a subjective decision — we simply expect you to use good judgement. Examples include: fixing build breakage, reverting obviously broken patches, documentation/comment changes, any other minor changes.'
- 'we tend to make much heavier use of reverts to keep the tree healthy than some other open source projects, and our norms are a bit different. ... Any time you learn of a serious problem with a change, you should revert it. We strongly encourage “revert to green” as opposed to “fixing forward”. We encourage reverting first, investigating offline, and then reapplying the fixed patch - possibly after another round of review if warranted.'
(https://llvm.org/docs/DeveloperPolicy.html)


https://github.com/llvm/llvm-project/pull/164137


More information about the llvm-commits mailing list