[clang] [llvm] [LifetimeSafety] Reorganize code into modular components (PR #162474)

[LLVM Continuous Integration via llvm-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `openmp-offload-amdgpu-runtime-2` running on `rocm-worker-hw-02` while building `.github,clang,llvm` at step 5 "compile-openmp".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/10/builds/15195

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (compile-openmp) failure: build (failure)
...
10.065 [1085/64/3614] Building CXX object tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/CheckerHelpers.cpp.o
10.135 [1084/64/3615] Building AMDGPUGenMCPseudoLowering.inc...
10.137 [1083/64/3616] Linking CXX shared library lib/libLLVMFuzzMutate.so.22.0git
10.146 [1082/64/3617] Creating library symlink lib/libLLVMFuzzMutate.so
10.229 [1081/64/3618] Building CXX object tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/Environment.cpp.o
10.246 [1080/64/3619] Linking CXX shared library lib/libLLVMFrontendOpenMP.so.22.0git
10.256 [1079/64/3620] Creating library symlink lib/libLLVMFrontendOpenMP.so
10.402 [1078/64/3621] Building CXX object tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/DynamicType.cpp.o
10.414 [1077/64/3622] Building CXX object tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/AnalysisManager.cpp.o
10.474 [1076/64/3623] Linking CXX shared library lib/libclangAnalysisLifetimeSafety.so.22.0git
FAILED: lib/libclangAnalysisLifetimeSafety.so.22.0git 
: && /usr/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-array-bounds -Wno-stringop-overread -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -Wno-pass-failed -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libclangAnalysisLifetimeSafety.so.22.0git -o lib/libclangAnalysisLifetimeSafety.so.22.0git tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/Checker.cpp.o tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/Facts.cpp.o tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/FactsGenerator.cpp.o tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/LifetimeAnnotations.cpp.o tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/LifetimeSafety.cpp.o tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/LiveOrigins.cpp.o tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/Loans.cpp.o tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/LoanPropagation.cpp.o tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/Origins.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/lib:"  lib/libLLVMFrontendOpenMP.so.22.0git  lib/libLLVMSupport.so.22.0git  -Wl,-rpath-link,/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/lib && :
/usr/bin/ld: tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/Checker.cpp.o: in function `clang::lifetimes::internal::runLifetimeChecker(clang::lifetimes::internal::LoanPropagationAnalysis const&, clang::lifetimes::internal::LiveOriginsAnalysis const&, clang::lifetimes::internal::FactManager const&, clang::AnalysisDeclContext&, clang::lifetimes::LifetimeSafetyReporter*)':
Checker.cpp:(.text._ZN5clang9lifetimes8internal18runLifetimeCheckerERKNS1_23LoanPropagationAnalysisERKNS1_19LiveOriginsAnalysisERKNS1_11FactManagerERNS_19AnalysisDeclContextEPNS0_22LifetimeSafetyReporterE+0xbb): undefined reference to `clang::PostOrderCFGView::getTag()'
/usr/bin/ld: Checker.cpp:(.text._ZN5clang9lifetimes8internal18runLifetimeCheckerERKNS1_23LoanPropagationAnalysisERKNS1_19LiveOriginsAnalysisERKNS1_11FactManagerERNS_19AnalysisDeclContextEPNS0_22LifetimeSafetyReporterE+0xc6): undefined reference to `clang::AnalysisDeclContext::getAnalysisImpl(void const*)'
/usr/bin/ld: Checker.cpp:(.text._ZN5clang9lifetimes8internal18runLifetimeCheckerERKNS1_23LoanPropagationAnalysisERKNS1_19LiveOriginsAnalysisERKNS1_11FactManagerERNS_19AnalysisDeclContextEPNS0_22LifetimeSafetyReporterE+0x10ad): undefined reference to `clang::PostOrderCFGView::create(clang::AnalysisDeclContext&)'
/usr/bin/ld: tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/FactsGenerator.cpp.o: in function `clang::lifetimes::internal::FactsGenerator::handleTestPoint(clang::CXXFunctionalCastExpr const*) [clone .localalias]':
FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator15handleTestPointEPKNS_21CXXFunctionalCastExprE+0xd9): undefined reference to `clang::Expr::IgnoreParenImpCasts()'
/usr/bin/ld: tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/FactsGenerator.cpp.o: in function `clang::lifetimes::internal::FactsGenerator::handleDestructor(clang::CFGAutomaticObjDtor const&) [clone .localalias]':
FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator16handleDestructorERKNS_19CFGAutomaticObjDtorE+0x70): undefined reference to `clang::Stmt::getEndLoc() const'
/usr/bin/ld: tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/FactsGenerator.cpp.o: in function `clang::lifetimes::internal::isGslPointerType(clang::QualType)':
FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internalL16isGslPointerTypeENS_8QualTypeE+0x9e): undefined reference to `clang::ClassTemplateSpecializationDecl::getSpecializedTemplate() const'
/usr/bin/ld: FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internalL16isGslPointerTypeENS_8QualTypeE+0xad): undefined reference to `clang::Decl::getAttrs() const'
/usr/bin/ld: FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internalL16isGslPointerTypeENS_8QualTypeE+0x11e): undefined reference to `clang::Decl::getAttrs() const'
/usr/bin/ld: tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/FactsGenerator.cpp.o: in function `clang::lifetimes::internal::FactsGenerator::handleFunctionCall(clang::Expr const*, clang::FunctionDecl const*, llvm::ArrayRef<clang::Expr const*>, bool) [clone .localalias]':
FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator18handleFunctionCallEPKNS_4ExprEPKNS_12FunctionDeclEN4llvm8ArrayRefIS5_EEb+0x294): undefined reference to `clang::CXXMethodDecl::isStatic() const'
/usr/bin/ld: FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator18handleFunctionCallEPKNS_4ExprEPKNS_12FunctionDeclEN4llvm8ArrayRefIS5_EEb+0x2ae): undefined reference to `clang::FunctionDecl::getNumParams() const'
/usr/bin/ld: FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator18handleFunctionCallEPKNS_4ExprEPKNS_12FunctionDeclEN4llvm8ArrayRefIS5_EEb+0x2c5): undefined reference to `clang::FunctionDecl::getNumParams() const'
/usr/bin/ld: FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator18handleFunctionCallEPKNS_4ExprEPKNS_12FunctionDeclEN4llvm8ArrayRefIS5_EEb+0x2f8): undefined reference to `clang::Decl::getAttrs() const'
/usr/bin/ld: FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator18handleFunctionCallEPKNS_4ExprEPKNS_12FunctionDeclEN4llvm8ArrayRefIS5_EEb+0x3a1): undefined reference to `clang::FunctionDecl::getNumParams() const'
/usr/bin/ld: FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator18handleFunctionCallEPKNS_4ExprEPKNS_12FunctionDeclEN4llvm8ArrayRefIS5_EEb+0x3b3): undefined reference to `clang::FunctionDecl::getNumParams() const'
/usr/bin/ld: tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/FactsGenerator.cpp.o: in function `clang::lifetimes::internal::FactsGenerator::VisitCallExpr(clang::CallExpr const*) [clone .localalias]':
FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator13VisitCallExprEPKNS_8CallExprE+0x64): undefined reference to `clang::Expr::getReferencedDeclOfCallee()'
/usr/bin/ld: tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/FactsGenerator.cpp.o: in function `clang::lifetimes::internal::FactsGenerator::VisitCXXMemberCallExpr(clang::CXXMemberCallExpr const*) [clone .localalias]':
FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator22VisitCXXMemberCallExprEPKNS_17CXXMemberCallExprE+0x79): undefined reference to `clang::Expr::getReferencedDeclOfCallee()'
/usr/bin/ld: FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator22VisitCXXMemberCallExprEPKNS_17CXXMemberCallExprE+0x99): undefined reference to `clang::CXXMemberCallExpr::getMethodDecl() const'
/usr/bin/ld: FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator22VisitCXXMemberCallExprEPKNS_17CXXMemberCallExprE+0xc8): undefined reference to `clang::CXXMemberCallExpr::getImplicitObjectArgument() const'
/usr/bin/ld: FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator22VisitCXXMemberCallExprEPKNS_17CXXMemberCallExprE+0x289): undefined reference to `clang::CXXMemberCallExpr::getImplicitObjectArgument() const'
/usr/bin/ld: FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator22VisitCXXMemberCallExprEPKNS_17CXXMemberCallExprE+0x296): undefined reference to `clang::CXXMemberCallExpr::getMethodDecl() const'
/usr/bin/ld: tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/FactsGenerator.cpp.o: in function `clang::lifetimes::internal::FactsGenerator::VisitDeclStmt(clang::DeclStmt const*) [clone .localalias]':
FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator13VisitDeclStmtEPKNS_8DeclStmtE+0xa7): undefined reference to `clang::VarDecl::getInit()'
/usr/bin/ld: tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/FactsGenerator.cpp.o: in function `clang::lifetimes::internal::FactsGenerator::handleAssignment(clang::Expr const*, clang::Expr const*) [clone .localalias]':
FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator16handleAssignmentEPKNS_4ExprES5_+0x25): undefined reference to `clang::Expr::IgnoreParenImpCasts()'
/usr/bin/ld: tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/FactsGenerator.cpp.o: in function `clang::lifetimes::internal::FactsGenerator::VisitCXXOperatorCallExpr(clang::CXXOperatorCallExpr const*) [clone .localalias]':
FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator24VisitCXXOperatorCallExprEPKNS_19CXXOperatorCallExprE+0xb1): undefined reference to `clang::Expr::getReferencedDeclOfCallee()'
/usr/bin/ld: tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/FactsGenerator.cpp.o: in function `clang::lifetimes::internal::FactsGenerator::VisitBinaryOperator(clang::BinaryOperator const*) [clone .part.0] [clone .isra.0]':
FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator19VisitBinaryOperatorEPKNS_14BinaryOperatorE.part.0.isra.0+0x7e): undefined reference to `clang::Expr::IgnoreParenImpCasts()'
/usr/bin/ld: tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/FactsGenerator.cpp.o: in function `clang::lifetimes::internal::FactsGenerator::run()':
FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator3runEv+0x44): undefined reference to `clang::PostOrderCFGView::getTag()'

```

</details>

https://github.com/llvm/llvm-project/pull/162474