[clang] [llvm] [LifetimeSafety] Reorganize code into modular components (PR #162474)

Fri Oct 10 04:55:10 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `amdgpu-offload-rhel-9-cmake-build-only` running on `rocm-docker-rhel-9` while building `.github,clang,llvm` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/205/builds/24628

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: '../llvm-zorg/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py --jobs=32' (failure)
...
-- Performing Test CXX_SUPPORTS_SUGGEST_OVERRIDE_FLAG
-- Performing Test CXX_SUPPORTS_SUGGEST_OVERRIDE_FLAG - Success
-- Performing Test CXX_WSUGGEST_OVERRIDE_ALLOWS_ONLY_FINAL
-- Performing Test CXX_WSUGGEST_OVERRIDE_ALLOWS_ONLY_FINAL - Success
-- Performing Test C_WCOMMENT_ALLOWS_LINE_WRAP
-- Performing Test C_WCOMMENT_ALLOWS_LINE_WRAP - Failed
-- Performing Test C_SUPPORTS_CTAD_MAYBE_UNSPPORTED_FLAG
-- Performing Test C_SUPPORTS_CTAD_MAYBE_UNSPPORTED_FLAG - Failed
-- Performing Test CXX_SUPPORTS_CTAD_MAYBE_UNSPPORTED_FLAG
-- Performing Test CXX_SUPPORTS_CTAD_MAYBE_UNSPPORTED_FLAG - Success
-- Performing Test C_SUPPORTS_NO_PASS_FAILED_FLAG
-- Performing Test C_SUPPORTS_NO_PASS_FAILED_FLAG - Success
-- Performing Test CXX_SUPPORTS_NO_PASS_FAILED_FLAG
-- Performing Test CXX_SUPPORTS_NO_PASS_FAILED_FLAG - Success
-- Performing Test LINKER_SUPPORTS_COLOR_DIAGNOSTICS
-- Performing Test LINKER_SUPPORTS_COLOR_DIAGNOSTICS - Failed
-- Looking for os_signpost_interval_begin
-- Looking for os_signpost_interval_begin - not found
-- Looking for flock
-- Looking for flock - found
-- Linker detection: GNU ld
-- Performing Test LLVM_LINKER_SUPPORTS_B_SYMBOLIC_FUNCTIONS
-- Performing Test LLVM_LINKER_SUPPORTS_B_SYMBOLIC_FUNCTIONS - Success
-- Performing Test HAS_WERROR_GLOBAL_CTORS
-- Performing Test HAS_WERROR_GLOBAL_CTORS - Failed
-- Looking for __x86_64__
-- Looking for __x86_64__ - found
-- Found Git: /usr/bin/git (found version "2.43.5") 
-- Looking for logf128
-- Looking for logf128 - found
-- Targeting AMDGPU
-- Targeting SPIRV
-- Targeting X86
-- LLD version: 22.0.0
-- Performing Test C_SUPPORTS_WERROR_IMPLICIT_FUNCTION_DECLARATION
-- Performing Test C_SUPPORTS_WERROR_IMPLICIT_FUNCTION_DECLARATION - Success
-- Performing Test C_SUPPORTS_WUNDEF
-- Performing Test C_SUPPORTS_WUNDEF - Success
-- Performing Test C_SUPPORTS_WERROR_MISMATCHED_TAGS
-- Performing Test C_SUPPORTS_WERROR_MISMATCHED_TAGS - Failed
-- Performing Test CXX_SUPPORTS_WNO_UNUSED_BUT_SET_PARAMETER
-- Performing Test CXX_SUPPORTS_WNO_UNUSED_BUT_SET_PARAMETER - Success
-- Performing Test CXX_SUPPORTS_WNO_DEPRECTAED_COPY
-- Performing Test CXX_SUPPORTS_WNO_DEPRECTAED_COPY - Success
-- Performing Test C_SUPPORTS_WERROR_GLOBAL_CONSTRUCTOR
-- Performing Test C_SUPPORTS_WERROR_GLOBAL_CONSTRUCTOR - Failed
-- Performing Test CXX_SUPPORTS_WERROR_GLOBAL_CONSTRUCTOR
-- Performing Test CXX_SUPPORTS_WERROR_GLOBAL_CONSTRUCTOR - Failed
-- Performing Test COMPILER_SUPPORTS_WARNING_WEAK_VTABLES
Step 7 (build cmake config) failure: build cmake config (failure)
...
[6403/8118] Building AMDGPUGenGlobalISel.inc...
[6404/8118] Building CXX object tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/EntryPointStats.cpp.o
[6405/8118] Linking CXX shared library lib/libclangInstallAPI.so.22.0git
[6406/8118] Creating library symlink lib/libclangInstallAPI.so
[6407/8118] Building CXX object tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/LoanPropagation.cpp.o
[6408/8118] Building AMDGPUGenDAGISel.inc...
[6409/8118] Building CXX object tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/FactsGenerator.cpp.o
[6410/8118] Building CXX object tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/BlockCounter.cpp.o
[6411/8118] Building AMDGPUGenInstrInfo.inc...
[6412/8118] Linking CXX shared library lib/libclangAnalysisLifetimeSafety.so.22.0git
FAILED: lib/libclangAnalysisLifetimeSafety.so.22.0git 
: && /usr/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-array-bounds -Wno-stringop-overread -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -Wno-pass-failed -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libclangAnalysisLifetimeSafety.so.22.0git -o lib/libclangAnalysisLifetimeSafety.so.22.0git tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/Checker.cpp.o tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/Facts.cpp.o tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/FactsGenerator.cpp.o tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/LifetimeAnnotations.cpp.o tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/LifetimeSafety.cpp.o tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/LiveOrigins.cpp.o tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/Loans.cpp.o tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/LoanPropagation.cpp.o tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/Origins.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/lib:"  lib/libLLVMFrontendOpenMP.so.22.0git  lib/libLLVMSupport.so.22.0git  -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/lib && :
/usr/bin/ld: tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/Checker.cpp.o: in function `clang::lifetimes::internal::runLifetimeChecker(clang::lifetimes::internal::LoanPropagationAnalysis const&, clang::lifetimes::internal::LiveOriginsAnalysis const&, clang::lifetimes::internal::FactManager const&, clang::AnalysisDeclContext&, clang::lifetimes::LifetimeSafetyReporter*)':
Checker.cpp:(.text._ZN5clang9lifetimes8internal18runLifetimeCheckerERKNS1_23LoanPropagationAnalysisERKNS1_19LiveOriginsAnalysisERKNS1_11FactManagerERNS_19AnalysisDeclContextEPNS0_22LifetimeSafetyReporterE+0xa0): undefined reference to `clang::PostOrderCFGView::getTag()'
/usr/bin/ld: Checker.cpp:(.text._ZN5clang9lifetimes8internal18runLifetimeCheckerERKNS1_23LoanPropagationAnalysisERKNS1_19LiveOriginsAnalysisERKNS1_11FactManagerERNS_19AnalysisDeclContextEPNS0_22LifetimeSafetyReporterE+0xab): undefined reference to `clang::AnalysisDeclContext::getAnalysisImpl(void const*)'
/usr/bin/ld: Checker.cpp:(.text._ZN5clang9lifetimes8internal18runLifetimeCheckerERKNS1_23LoanPropagationAnalysisERKNS1_19LiveOriginsAnalysisERKNS1_11FactManagerERNS_19AnalysisDeclContextEPNS0_22LifetimeSafetyReporterE+0xfd1): undefined reference to `clang::PostOrderCFGView::create(clang::AnalysisDeclContext&)'
/usr/bin/ld: tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/FactsGenerator.cpp.o: in function `clang::lifetimes::internal::FactsGenerator::handleTestPoint(clang::CXXFunctionalCastExpr const*) [clone .localalias]':
FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator15handleTestPointEPKNS_21CXXFunctionalCastExprE+0xc9): undefined reference to `clang::Expr::IgnoreParenImpCasts()'
/usr/bin/ld: tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/FactsGenerator.cpp.o: in function `clang::lifetimes::internal::FactsGenerator::handleDestructor(clang::CFGAutomaticObjDtor const&) [clone .localalias]':
FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator16handleDestructorERKNS_19CFGAutomaticObjDtorE+0x70): undefined reference to `clang::Stmt::getEndLoc() const'
/usr/bin/ld: tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/FactsGenerator.cpp.o: in function `clang::lifetimes::internal::isGslPointerType(clang::QualType)':
FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internalL16isGslPointerTypeENS_8QualTypeE+0x9e): undefined reference to `clang::ClassTemplateSpecializationDecl::getSpecializedTemplate() const'
/usr/bin/ld: FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internalL16isGslPointerTypeENS_8QualTypeE+0xad): undefined reference to `clang::Decl::getAttrs() const'
/usr/bin/ld: FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internalL16isGslPointerTypeENS_8QualTypeE+0x11e): undefined reference to `clang::Decl::getAttrs() const'
/usr/bin/ld: tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/FactsGenerator.cpp.o: in function `clang::lifetimes::internal::FactsGenerator::handleFunctionCall(clang::Expr const*, clang::FunctionDecl const*, llvm::ArrayRef<clang::Expr const*>, bool) [clone .localalias]':
FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator18handleFunctionCallEPKNS_4ExprEPKNS_12FunctionDeclEN4llvm8ArrayRefIS5_EEb+0x292): undefined reference to `clang::CXXMethodDecl::isStatic() const'
/usr/bin/ld: FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator18handleFunctionCallEPKNS_4ExprEPKNS_12FunctionDeclEN4llvm8ArrayRefIS5_EEb+0x2ac): undefined reference to `clang::FunctionDecl::getNumParams() const'
/usr/bin/ld: FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator18handleFunctionCallEPKNS_4ExprEPKNS_12FunctionDeclEN4llvm8ArrayRefIS5_EEb+0x2c3): undefined reference to `clang::FunctionDecl::getNumParams() const'
/usr/bin/ld: FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator18handleFunctionCallEPKNS_4ExprEPKNS_12FunctionDeclEN4llvm8ArrayRefIS5_EEb+0x2f6): undefined reference to `clang::Decl::getAttrs() const'
/usr/bin/ld: FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator18handleFunctionCallEPKNS_4ExprEPKNS_12FunctionDeclEN4llvm8ArrayRefIS5_EEb+0x3a1): undefined reference to `clang::FunctionDecl::getNumParams() const'
/usr/bin/ld: FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator18handleFunctionCallEPKNS_4ExprEPKNS_12FunctionDeclEN4llvm8ArrayRefIS5_EEb+0x3b3): undefined reference to `clang::FunctionDecl::getNumParams() const'
/usr/bin/ld: tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/FactsGenerator.cpp.o: in function `clang::lifetimes::internal::FactsGenerator::VisitCallExpr(clang::CallExpr const*) [clone .localalias]':
FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator13VisitCallExprEPKNS_8CallExprE+0x64): undefined reference to `clang::Expr::getReferencedDeclOfCallee()'
/usr/bin/ld: tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/FactsGenerator.cpp.o: in function `clang::lifetimes::internal::FactsGenerator::VisitCXXMemberCallExpr(clang::CXXMemberCallExpr const*) [clone .localalias]':
FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator22VisitCXXMemberCallExprEPKNS_17CXXMemberCallExprE+0x61): undefined reference to `clang::Expr::getReferencedDeclOfCallee()'
/usr/bin/ld: FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator22VisitCXXMemberCallExprEPKNS_17CXXMemberCallExprE+0x81): undefined reference to `clang::CXXMemberCallExpr::getMethodDecl() const'
/usr/bin/ld: FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator22VisitCXXMemberCallExprEPKNS_17CXXMemberCallExprE+0xb0): undefined reference to `clang::CXXMemberCallExpr::getImplicitObjectArgument() const'
/usr/bin/ld: FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator22VisitCXXMemberCallExprEPKNS_17CXXMemberCallExprE+0x261): undefined reference to `clang::CXXMemberCallExpr::getImplicitObjectArgument() const'
/usr/bin/ld: FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator22VisitCXXMemberCallExprEPKNS_17CXXMemberCallExprE+0x26e): undefined reference to `clang::CXXMemberCallExpr::getMethodDecl() const'
/usr/bin/ld: tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/FactsGenerator.cpp.o: in function `clang::lifetimes::internal::FactsGenerator::VisitDeclStmt(clang::DeclStmt const*) [clone .localalias]':
FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator13VisitDeclStmtEPKNS_8DeclStmtE+0xa7): undefined reference to `clang::VarDecl::getInit()'
/usr/bin/ld: tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/FactsGenerator.cpp.o: in function `clang::lifetimes::internal::FactsGenerator::handleAssignment(clang::Expr const*, clang::Expr const*) [clone .localalias]':
FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator16handleAssignmentEPKNS_4ExprES5_+0x21): undefined reference to `clang::Expr::IgnoreParenImpCasts()'
/usr/bin/ld: tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/FactsGenerator.cpp.o: in function `clang::lifetimes::internal::FactsGenerator::VisitCXXOperatorCallExpr(clang::CXXOperatorCallExpr const*) [clone .localalias]':
FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator24VisitCXXOperatorCallExprEPKNS_19CXXOperatorCallExprE+0xa9): undefined reference to `clang::Expr::getReferencedDeclOfCallee()'
/usr/bin/ld: tools/clang/lib/Analysis/LifetimeSafety/CMakeFiles/obj.clangAnalysisLifetimeSafety.dir/FactsGenerator.cpp.o: in function `clang::lifetimes::internal::FactsGenerator::run()':
FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator3runEv+0x30): undefined reference to `clang::PostOrderCFGView::getTag()'
/usr/bin/ld: FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator3runEv+0x3b): undefined reference to `clang::AnalysisDeclContext::getAnalysisImpl(void const*)'
/usr/bin/ld: FactsGenerator.cpp:(.text._ZN5clang9lifetimes8internal14FactsGenerator3runEv+0x30e): undefined reference to `clang::PostOrderCFGView::create(clang::AnalysisDeclContext&)'

```

</details>

https://github.com/llvm/llvm-project/pull/162474