[lld] [llvm] [llvm-readobj][ELF] Print ELF e_entry in lowercase mode (PR #156683)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 4 01:45:53 PDT 2025


https://github.com/jh7370 commented:

Thanks for the PR! In principle, I think this makes sense. The majority of our hex printing is via `Twine::utohexstr`, which is always lower-case. I think the missing lower case argument in the calls to `llvm::utohexstr` are likely just oversights and should be updated.

There are several other places in this file that use `llvm::utohexstr`, some of which don't use the lower-case argument. Please could you update them all (and any tests that fail as a result of course). I note that in some cases (e.g. e_version), it's unlikely to matter due to the range of values that could be printed, but it's better to be consistent.

https://github.com/llvm/llvm-project/pull/156683


More information about the llvm-commits mailing list