[lld] [llvm] [llvm-readobj][ELF] Print ELF e_entry in lowercase mode (PR #156683)
Ádám Kallai via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 4 00:47:32 PDT 2025
https://github.com/kaadam updated https://github.com/llvm/llvm-project/pull/156683
>From 5d4ac87a186463f879881f4ad954694a9405fb59 Mon Sep 17 00:00:00 2001
From: Adam Kallai <kadam at inf.u-szeged.hu>
Date: Wed, 3 Sep 2025 16:16:26 +0200
Subject: [PATCH 1/2] [llvm-readobj][ELF] Print ELF e_entry in lowercase mode
Currently llvm-readobj prints e_entry address in uppercase mode,
however all other places such as symbols, relocs the addresses
are printed in lowercase mode. This PR aims to print the addresses
in uniform manner.
Other use-case:
FileCheck comparison is case-sensitive by default, so if you would
like to compare e_entry address with the same address in the symbol
table it won't match by default.
---
llvm/tools/llvm-readobj/ELFDumper.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/llvm/tools/llvm-readobj/ELFDumper.cpp b/llvm/tools/llvm-readobj/ELFDumper.cpp
index a440bad130f4c..79a6ce1fd88b8 100644
--- a/llvm/tools/llvm-readobj/ELFDumper.cpp
+++ b/llvm/tools/llvm-readobj/ELFDumper.cpp
@@ -3640,7 +3640,7 @@ template <class ELFT> void GNUELFDumper<ELFT>::printFileHeaders() {
printFields(OS, "Machine:", Str);
Str = "0x" + utohexstr(e.e_version);
printFields(OS, "Version:", Str);
- Str = "0x" + utohexstr(e.e_entry);
+ Str = "0x" + utohexstr(e.e_entry, /*LowerCase=*/true);
printFields(OS, "Entry point address:", Str);
Str = to_string(e.e_phoff) + " (bytes into file)";
printFields(OS, "Start of program headers:", Str);
>From 87b76e7796a7640b59becb410ce3d6b1512d1e5f Mon Sep 17 00:00:00 2001
From: Adam Kallai <kadam at inf.u-szeged.hu>
Date: Thu, 4 Sep 2025 09:46:11 +0200
Subject: [PATCH 2/2] Adjust hexagon test to the new lowercase format
---
lld/test/ELF/emulation-hexagon.s | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lld/test/ELF/emulation-hexagon.s b/lld/test/ELF/emulation-hexagon.s
index 5bdd88941c269..df692ef99ef5f 100644
--- a/lld/test/ELF/emulation-hexagon.s
+++ b/lld/test/ELF/emulation-hexagon.s
@@ -23,7 +23,7 @@
# CHECK-NEXT: Type: EXEC (Executable file)
# CHECK-NEXT: Machine: Qualcomm Hexagon
# CHECK-NEXT: Version: 0x1
-# CHECK-NEXT: Entry point address: 0x200B4
+# CHECK-NEXT: Entry point address: 0x200b4
# CHECK-NEXT: Start of program headers: 52 (bytes into file)
# CHECK-NEXT: Start of section headers:
# CHECK-NEXT: Flags: 0x73
More information about the llvm-commits
mailing list