[llvm] [ARM] Simplify LowerCMP (NFC) (PR #156198)
via llvm-commits
llvm-commits at lists.llvm.org
Sat Aug 30 12:12:06 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-arm
Author: AZero13 (AZero13)
<details>
<summary>Changes</summary>
Pass the opcode directly.
---
Full diff: https://github.com/llvm/llvm-project/pull/156198.diff
1 Files Affected:
- (modified) llvm/lib/Target/ARM/ARMISelLowering.cpp (+2-10)
``````````diff
diff --git a/llvm/lib/Target/ARM/ARMISelLowering.cpp b/llvm/lib/Target/ARM/ARMISelLowering.cpp
index ea74d6a2071d9..147b710d6df43 100644
--- a/llvm/lib/Target/ARM/ARMISelLowering.cpp
+++ b/llvm/lib/Target/ARM/ARMISelLowering.cpp
@@ -10539,16 +10539,8 @@ SDValue ARMTargetLowering::LowerCMP(SDValue Op, SelectionDAG &DAG) const {
}
// Generate the operation with flags
- SDValue OpWithFlags;
- if (Opcode == ARMISD::ADDC) {
- // Use ADDC: LHS + RHS (where RHS was 0 - X, now X)
- OpWithFlags = DAG.getNode(ARMISD::ADDC, dl,
- DAG.getVTList(MVT::i32, FlagsVT), LHS, RHS);
- } else {
- // Use ARMISD::SUBC to generate SUBS instruction (subtract with flags)
- OpWithFlags = DAG.getNode(ARMISD::SUBC, dl,
- DAG.getVTList(MVT::i32, FlagsVT), LHS, RHS);
- }
+ SDValue OpWithFlags = DAG.getNode(Opcode, dl,
+ DAG.getVTList(MVT::i32, FlagsVT), LHS, RHS);
SDValue OpResult = OpWithFlags.getValue(0); // The operation result
SDValue Flags = OpWithFlags.getValue(1); // The flags
``````````
</details>
https://github.com/llvm/llvm-project/pull/156198
More information about the llvm-commits
mailing list