[llvm] [ARM] Add missing optimize compare candidates to isOptimizeCompareCandidates (PR #155886)

via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 30 08:04:20 PDT 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp b/llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp
index 585edf31c..7e85af1fc 100644
--- a/llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp
+++ b/llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp
@@ -2263,44 +2263,30 @@ struct AddSubFlagsOpcodePair {
 };
 
 static const AddSubFlagsOpcodePair AddSubFlagsOpcodeMap[] = {
-  {ARM::ADDSri, ARM::ADDri},
-  {ARM::ADDSrr, ARM::ADDrr},
-  {ARM::ADDSrsi, ARM::ADDrsi},
-  {ARM::ADDSrsr, ARM::ADDrsr},
-
-  {ARM::SUBSri, ARM::SUBri},
-  {ARM::SUBSrr, ARM::SUBrr},
-  {ARM::SUBSrsi, ARM::SUBrsi},
-  {ARM::SUBSrsr, ARM::SUBrsr},
-
-  {ARM::RSBSri, ARM::RSBri},
-  {ARM::RSBSrr, ARM::RSBrr},
-  {ARM::RSBSrsi, ARM::RSBrsi},
-  {ARM::RSBSrsr, ARM::RSBrsr},
-
-  {ARM::tADDSi3, ARM::tADDi3},
-  {ARM::tADDSi8, ARM::tADDi8},
-  {ARM::tADDSrr, ARM::tADDrr},
-  {ARM::tADCS, ARM::tADC},
-
-  {ARM::tSUBSi3, ARM::tSUBi3},
-  {ARM::tSUBSi8, ARM::tSUBi8},
-  {ARM::tSUBSrr, ARM::tSUBrr},
-  {ARM::tSBCS, ARM::tSBC},
-  {ARM::tRSBS, ARM::tRSB},
-  {ARM::tLSLSri, ARM::tLSLri},
-
-  {ARM::t2ADDSri, ARM::t2ADDri},
-  {ARM::t2ADDSrr, ARM::t2ADDrr},
-  {ARM::t2ADDSrs, ARM::t2ADDrs},
-
-  {ARM::t2SUBSri, ARM::t2SUBri},
-  {ARM::t2SUBSrr, ARM::t2SUBrr},
-  {ARM::t2SUBSrs, ARM::t2SUBrs},
-
-  {ARM::t2RSBSri, ARM::t2RSBri},
-  {ARM::t2RSBSrr, ARM::t2RSBrr},
-  {ARM::t2RSBSrs, ARM::t2RSBrs},
+    {ARM::ADDSri, ARM::ADDri},     {ARM::ADDSrr, ARM::ADDrr},
+    {ARM::ADDSrsi, ARM::ADDrsi},   {ARM::ADDSrsr, ARM::ADDrsr},
+
+    {ARM::SUBSri, ARM::SUBri},     {ARM::SUBSrr, ARM::SUBrr},
+    {ARM::SUBSrsi, ARM::SUBrsi},   {ARM::SUBSrsr, ARM::SUBrsr},
+
+    {ARM::RSBSri, ARM::RSBri},     {ARM::RSBSrr, ARM::RSBrr},
+    {ARM::RSBSrsi, ARM::RSBrsi},   {ARM::RSBSrsr, ARM::RSBrsr},
+
+    {ARM::tADDSi3, ARM::tADDi3},   {ARM::tADDSi8, ARM::tADDi8},
+    {ARM::tADDSrr, ARM::tADDrr},   {ARM::tADCS, ARM::tADC},
+
+    {ARM::tSUBSi3, ARM::tSUBi3},   {ARM::tSUBSi8, ARM::tSUBi8},
+    {ARM::tSUBSrr, ARM::tSUBrr},   {ARM::tSBCS, ARM::tSBC},
+    {ARM::tRSBS, ARM::tRSB},       {ARM::tLSLSri, ARM::tLSLri},
+
+    {ARM::t2ADDSri, ARM::t2ADDri}, {ARM::t2ADDSrr, ARM::t2ADDrr},
+    {ARM::t2ADDSrs, ARM::t2ADDrs},
+
+    {ARM::t2SUBSri, ARM::t2SUBri}, {ARM::t2SUBSrr, ARM::t2SUBrr},
+    {ARM::t2SUBSrs, ARM::t2SUBrs},
+
+    {ARM::t2RSBSri, ARM::t2RSBri}, {ARM::t2RSBSrr, ARM::t2RSBrr},
+    {ARM::t2RSBSrs, ARM::t2RSBrs},
 };
 
 unsigned llvm::convertAddSubFlagsOpcode(unsigned OldOpc) {

``````````

</details>


https://github.com/llvm/llvm-project/pull/155886


More information about the llvm-commits mailing list