[llvm] [NFC][AMDGPU] Remove redundant code in `AMDGPUSubtarget::getWavesPerEU` (PR #155201)
Shilei Tian via llvm-commits
llvm-commits at lists.llvm.org
Sun Aug 24 21:18:07 PDT 2025
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/155201
>From fa43df7e57c14ed46765556dcf8b68457df78a69 Mon Sep 17 00:00:00 2001
From: Shilei Tian <i at tianshilei.me>
Date: Mon, 25 Aug 2025 00:05:13 -0400
Subject: [PATCH] [NFC][AMDGPU] Remove redundant code in
`AMDGPUSubtarget::getWavesPerEU`
---
llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp b/llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp
index d095fc6cf9549..a1d82128423bb 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp
@@ -209,19 +209,16 @@ std::pair<unsigned, unsigned>
AMDGPUSubtarget::getWavesPerEU(const Function &F) const {
// Default/requested minimum/maximum flat work group sizes.
std::pair<unsigned, unsigned> FlatWorkGroupSizes = getFlatWorkGroupSizes(F);
- // Minimum number of bytes allocated in the LDS.
- unsigned LDSBytes = AMDGPU::getIntegerPairAttribute(F, "amdgpu-lds-size",
- {0, UINT32_MAX}, true)
- .first;
- return getWavesPerEU(FlatWorkGroupSizes, LDSBytes, F);
+ return getWavesPerEU(F, FlatWorkGroupSizes);
}
std::pair<unsigned, unsigned> AMDGPUSubtarget::getWavesPerEU(
const Function &F, std::pair<unsigned, unsigned> FlatWorkGroupSizes) const {
// Minimum number of bytes allocated in the LDS.
- unsigned LDSBytes = AMDGPU::getIntegerPairAttribute(F, "amdgpu-lds-size",
- {0, UINT32_MAX}, true)
- .first;
+ unsigned LDSBytes =
+ AMDGPU::getIntegerPairAttribute(F, "amdgpu-lds-size", {0, UINT32_MAX},
+ /*OnlyFirstRequired=*/true)
+ .first;
return getWavesPerEU(FlatWorkGroupSizes, LDSBytes, F);
}
More information about the llvm-commits
mailing list