[llvm] b147644 - [ADT] Simplify SmallDenseMap::swap (NFC) (#155067)

via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 23 07:09:44 PDT 2025


Author: Kazu Hirata
Date: 2025-08-23T07:09:41-07:00
New Revision: b147644f182799f85741dd690ea6139643f2300a

URL: https://github.com/llvm/llvm-project/commit/b147644f182799f85741dd690ea6139643f2300a
DIFF: https://github.com/llvm/llvm-project/commit/b147644f182799f85741dd690ea6139643f2300a.diff

LOG: [ADT] Simplify SmallDenseMap::swap (NFC) (#155067)

This patch simplifies the swapping of *getLargeRep().

In other places, we treat the two member variables together like:

  new (getLargeRep()) LargeRep(allocateBuckets(InitBuckets));

This patch makes the code a little more consistent with other places
copying/moving LargeRep.

Added: 
    

Modified: 
    llvm/include/llvm/ADT/DenseMap.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/ADT/DenseMap.h b/llvm/include/llvm/ADT/DenseMap.h
index 2a35c3d583f70..156894aa7f0e3 100644
--- a/llvm/include/llvm/ADT/DenseMap.h
+++ b/llvm/include/llvm/ADT/DenseMap.h
@@ -1038,8 +1038,7 @@ class SmallDenseMap
       return;
     }
     if (!Small && !RHS.Small) {
-      std::swap(getLargeRep()->Buckets, RHS.getLargeRep()->Buckets);
-      std::swap(getLargeRep()->NumBuckets, RHS.getLargeRep()->NumBuckets);
+      std::swap(*getLargeRep(), *RHS.getLargeRep());
       return;
     }
 


        


More information about the llvm-commits mailing list