[llvm] [ADT] Simplify SmallDenseMap::swap (NFC) (PR #155067)

via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 22 20:55:07 PDT 2025


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-llvm-adt

Author: Kazu Hirata (kazutakahirata)

<details>
<summary>Changes</summary>

This patch simplifies the swapping of *getLargeRep().

In other places, we treat the two member variables together like:

  new (getLargeRep()) LargeRep(allocateBuckets(InitBuckets));

This patch makes the code a little more consistent with other places
copying/moving LargeRep.


---
Full diff: https://github.com/llvm/llvm-project/pull/155067.diff


1 Files Affected:

- (modified) llvm/include/llvm/ADT/DenseMap.h (+1-2) 


``````````diff
diff --git a/llvm/include/llvm/ADT/DenseMap.h b/llvm/include/llvm/ADT/DenseMap.h
index 2a35c3d583f70..156894aa7f0e3 100644
--- a/llvm/include/llvm/ADT/DenseMap.h
+++ b/llvm/include/llvm/ADT/DenseMap.h
@@ -1038,8 +1038,7 @@ class SmallDenseMap
       return;
     }
     if (!Small && !RHS.Small) {
-      std::swap(getLargeRep()->Buckets, RHS.getLargeRep()->Buckets);
-      std::swap(getLargeRep()->NumBuckets, RHS.getLargeRep()->NumBuckets);
+      std::swap(*getLargeRep(), *RHS.getLargeRep());
       return;
     }
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/155067


More information about the llvm-commits mailing list