[llvm] [compiler-rt] Add some missing dependencies on Windows (PR #155019)

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 22 13:00:25 PDT 2025


rnk wrote:

This prompted me to do some archeology on the use of KillTheDoctor, since I don't recall it being relevant to Windows LLVM testing for years. We have a bunch of changes in Support to suppress dialogs in LLVM binaries, so there are no references to KillTheDoctor in the LLVM/Clang test suites. I wondered if we still need this for compiler-rt. Blame took me back to @pcc 's change in 2015 https://reviews.llvm.org/D10864 / a68d90fa529222a155923fd294da790cbd0630ad . I think we still need it because the compiler-rt test suites use execution tests, where we build binaries that don't link in that LLVMSupport functionality to disable crash dialogs. 🤷  

https://github.com/llvm/llvm-project/pull/155019


More information about the llvm-commits mailing list