[llvm] [NFC][MC][MSP430] Rearrange decoder functions for MSP430 disassembler (PR #155011)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 22 12:32:55 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-msp430
Author: Rahul Joshi (jurahul)
<details>
<summary>Changes</summary>
Rearrange decode functions to be before including the generated disassembler code and eliminate forward declarations.
---
Full diff: https://github.com/llvm/llvm-project/pull/155011.diff
1 Files Affected:
- (modified) llvm/lib/Target/MSP430/Disassembler/MSP430Disassembler.cpp (+2-9)
``````````diff
diff --git a/llvm/lib/Target/MSP430/Disassembler/MSP430Disassembler.cpp b/llvm/lib/Target/MSP430/Disassembler/MSP430Disassembler.cpp
index c8094a8eeb361..e6666e8cafdf9 100644
--- a/llvm/lib/Target/MSP430/Disassembler/MSP430Disassembler.cpp
+++ b/llvm/lib/Target/MSP430/Disassembler/MSP430Disassembler.cpp
@@ -102,15 +102,6 @@ static DecodeStatus DecodeGR16RegisterClass(MCInst &MI, uint64_t RegNo,
return MCDisassembler::Success;
}
-static DecodeStatus DecodeCGImm(MCInst &MI, uint64_t Bits, uint64_t Address,
- const MCDisassembler *Decoder);
-
-static DecodeStatus DecodeMemOperand(MCInst &MI, uint64_t Bits,
- uint64_t Address,
- const MCDisassembler *Decoder);
-
-#include "MSP430GenDisassemblerTables.inc"
-
static DecodeStatus DecodeCGImm(MCInst &MI, uint64_t Bits, uint64_t Address,
const MCDisassembler *Decoder) {
int64_t Imm;
@@ -142,6 +133,8 @@ static DecodeStatus DecodeMemOperand(MCInst &MI, uint64_t Bits,
return MCDisassembler::Success;
}
+#include "MSP430GenDisassemblerTables.inc"
+
enum AddrMode {
amInvalid = 0,
amRegister,
``````````
</details>
https://github.com/llvm/llvm-project/pull/155011
More information about the llvm-commits
mailing list