[compiler-rt] [rtsan] Fix ioctl args in interceptor test (PR #154959)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 22 07:31:04 PDT 2025
https://github.com/davidtrevelyan updated https://github.com/llvm/llvm-project/pull/154959
>From d35ff601556fddae33de9eb91fcefd24e462858f Mon Sep 17 00:00:00 2001
From: David Trevelyan <david.trevelyan at gmail.com>
Date: Fri, 22 Aug 2025 15:13:32 +0100
Subject: [PATCH] [rtsan] Fix ioctl args in interceptor test
---
.../rtsan/tests/rtsan_test_interceptors_posix.cpp | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/compiler-rt/lib/rtsan/tests/rtsan_test_interceptors_posix.cpp b/compiler-rt/lib/rtsan/tests/rtsan_test_interceptors_posix.cpp
index 9b684e36e3b35..d69a4e74825f0 100644
--- a/compiler-rt/lib/rtsan/tests/rtsan_test_interceptors_posix.cpp
+++ b/compiler-rt/lib/rtsan/tests/rtsan_test_interceptors_posix.cpp
@@ -753,15 +753,24 @@ TEST_F(RtsanOpenedFileTest, RewindDieWhenRealtime) {
#endif
TEST_F(RtsanOpenedFileTest, IoctlDiesWhenRealtime) {
- auto Func = [this]() { ioctl(GetOpenFd(), FIONREAD); };
+ auto Func = [this]() {
+ int arg{};
+ ioctl(GetOpenFd(), FIONREAD, &arg);
+ EXPECT_THAT(arg, Ge(0));
+ };
ExpectRealtimeDeath(Func, "ioctl");
ExpectNonRealtimeSurvival(Func);
}
+TEST_F(RtsanOpenedFileTest, IoctlBehavesWithoutOutputArg) {
+ const int result = ioctl(GetOpenFd(), FIONCLEX);
+ EXPECT_THAT(result, Ne(-1));
+}
+
TEST_F(RtsanOpenedFileTest, IoctlBehavesWithOutputArg) {
int arg{};
- ioctl(GetOpenFd(), FIONREAD, &arg);
-
+ const int result = ioctl(GetOpenFd(), FIONREAD, &arg);
+ ASSERT_THAT(result, Ne(-1));
EXPECT_THAT(arg, Ge(0));
}
More information about the llvm-commits
mailing list