[llvm] big archive recognition by the llvm-symbolizer (PR #150401)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 22 01:14:04 PDT 2025


================
@@ -196,11 +196,17 @@ class LLVMSymbolizer {
   Expected<ObjectPair> getOrCreateObjectPair(const std::string &Path,
                                              const std::string &ArchName);
 
-  /// Return a pointer to object file at specified path, for a specified
+  /// Return a pointer to the object file at specified path, for a specified
   /// architecture (e.g. if path refers to a Mach-O universal binary, only one
   /// object file from it will be returned).
-  Expected<ObjectFile *> getOrCreateObject(const std::string &Path,
-                                           const std::string &ArchName);
+  Expected<ObjectFile *> getOrCreateObject(const std::string &InputPath,
+                                           const std::string &DefaultArchName);
+
+  /// Return a pointer to the object file at specified path, for a specified
----------------
jh7370 wrote:

Coming back to this, the first part of this comment needs improving.
```suggestion
  /// Return a pointer to the object file with the specified name, for a specified
```

https://github.com/llvm/llvm-project/pull/150401


More information about the llvm-commits mailing list