[llvm] [TableGen] Remove dummy UINT64_C(0) from end of InstBits table. NFC (PR #154778)

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 21 07:57:36 PDT 2025


https://github.com/topperc created https://github.com/llvm/llvm-project/pull/154778

I suspect this originally existed to avoid a trailing comma from the previous entry. C++ allows trailing commas in arrays so this isn't necessary.

>From 766f0c064ec23919e11c6a9cad6714fcf0881997 Mon Sep 17 00:00:00 2001
From: Craig Topper <craig.topper at sifive.com>
Date: Thu, 21 Aug 2025 07:53:13 -0700
Subject: [PATCH] [TableGen] Remove dummy UINT64_C(0) from end of InstBits
 table.

I suspect this originally existed to avoid a trailing comma from
the previous entry. C++ allows trailing commas in arrays so this
isn't necessary.
---
 llvm/utils/TableGen/CodeEmitterGen.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/utils/TableGen/CodeEmitterGen.cpp b/llvm/utils/TableGen/CodeEmitterGen.cpp
index d7b5e21c3f1fb..be468b012a8b7 100644
--- a/llvm/utils/TableGen/CodeEmitterGen.cpp
+++ b/llvm/utils/TableGen/CodeEmitterGen.cpp
@@ -440,7 +440,7 @@ void CodeEmitterGen::emitInstructionBaseValues(
     emitInstBits(O, Value);
     O << "," << '\t' << "// " << R->getName() << "\n";
   }
-  O << "    UINT64_C(0)\n  };\n";
+  O << "  };\n";
 }
 
 void CodeEmitterGen::emitCaseMap(



More information about the llvm-commits mailing list