[llvm] [hwasan] Add hwasan-static-linking option (PR #154529)

Florian Mayer via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 20 13:28:47 PDT 2025


================
@@ -547,6 +553,9 @@ void HWAddressSanitizer::createHwasanCtorComdat() {
             appendToGlobalCtors(M, Ctor, 0, Ctor);
           });
 
+  if (ClStaticLinking)
----------------
fmayer wrote:

I think it would be cleaner to pull the code below out into a function, and call that `if (!ClStaticLinking)`. Otherwise someone might add something to the end not realizing this early return in the long function.

Also please add a comment to the same effect of the commit message explaining what this is for.

https://github.com/llvm/llvm-project/pull/154529


More information about the llvm-commits mailing list