[llvm] [SCEVExp] Use Builder.CreateBinOp in InsertBinOp. (PR #154148)

[Florian Hahn via llvm-commits]

https://github.com/fhahn commented:

> Hm, this patch looks familiar...
> 

Ah yes, I missed this one...

> I guess I'll repeat this question here: [#146443 (comment)](https://github.com/llvm/llvm-project/pull/146443#discussion_r2177156151)
>
>> Without looking into it too deeply, changes like this might be problematic for LSR? Now the live-out is going to be the pre-inc IV rather than the post-inc one. (LSR should probably be wrapping things into Unknown in cases where it cares.)

Hm, I think expansion in LSR happens after analysis, so I am not sure if there would be any impact? If so, we could disable this if we are in LSRMode. But from the regression tests, it seems like all changes should be improvements I think


https://github.com/llvm/llvm-project/pull/154148