[llvm] 8b2028c - Update log_level for LLVM_DEBUG and associated macros (#154525)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 20 06:31:17 PDT 2025
Author: Mehdi Amini
Date: 2025-08-20T13:31:13Z
New Revision: 8b2028ced68527b50826d84ee3401c0a10502210
URL: https://github.com/llvm/llvm-project/commit/8b2028ced68527b50826d84ee3401c0a10502210
DIFF: https://github.com/llvm/llvm-project/commit/8b2028ced68527b50826d84ee3401c0a10502210.diff
LOG: Update log_level for LLVM_DEBUG and associated macros (#154525)
During the review of #150855 we switched from 0 to 1 for the default log
level used, but this macro wasn't updated.
Added:
Modified:
llvm/include/llvm/Support/Debug.h
llvm/unittests/Support/DebugTest.cpp
Removed:
################################################################################
diff --git a/llvm/include/llvm/Support/Debug.h b/llvm/include/llvm/Support/Debug.h
index a232b2ceecd3a..a6ed645849ded 100644
--- a/llvm/include/llvm/Support/Debug.h
+++ b/llvm/include/llvm/Support/Debug.h
@@ -71,7 +71,7 @@ LLVM_ABI void setCurrentDebugTypes(const char **Types, unsigned Count);
/// is not specified, or is specified as "bitset".
#define DEBUG_WITH_TYPE(TYPE, ...) \
do { \
- if (::llvm::DebugFlag && ::llvm::isCurrentDebugType(TYPE)) { \
+ if (::llvm::DebugFlag && ::llvm::isCurrentDebugType(TYPE, 1)) { \
__VA_ARGS__; \
} \
} while (false)
diff --git a/llvm/unittests/Support/DebugTest.cpp b/llvm/unittests/Support/DebugTest.cpp
index e8b754892a4c2..ed8bfc63f0648 100644
--- a/llvm/unittests/Support/DebugTest.cpp
+++ b/llvm/unittests/Support/DebugTest.cpp
@@ -50,4 +50,46 @@ TEST(DebugTest, CommaInDebugBlock) {
});
EXPECT_EQ("ZYX", os1.str());
}
+
+TEST(DebugTest, DebugWithType) {
+ llvm::DebugFlag = true;
+
+ // Check if the DEBUG_WITH_TYPE macro is enabled for the given type.
+ auto CheckDebugWithType = [](const char *Type) {
+ bool Visited = false;
+ DEBUG_WITH_TYPE(Type, { Visited = true; });
+ return Visited;
+ };
+
+ {
+ static const char *DT[] = {"A", "B"};
+ setCurrentDebugTypes(DT, sizeof(DT) / sizeof(DT[0]));
+ EXPECT_TRUE(CheckDebugWithType("A"));
+ EXPECT_TRUE(CheckDebugWithType("B"));
+ EXPECT_FALSE(CheckDebugWithType("C"));
+ }
+ {
+ static const char *DT[] = {"A:"};
+ setCurrentDebugTypes(DT, sizeof(DT) / sizeof(DT[0]));
+ EXPECT_FALSE(CheckDebugWithType("A"));
+ EXPECT_TRUE(CheckDebugWithType("B"));
+ EXPECT_TRUE(CheckDebugWithType("C"));
+ }
+ {
+ static const char *DT[] = {"A:", "B"};
+ setCurrentDebugTypes(DT, sizeof(DT) / sizeof(DT[0]));
+ EXPECT_FALSE(CheckDebugWithType("A"));
+ EXPECT_TRUE(CheckDebugWithType("B"));
+ EXPECT_FALSE(CheckDebugWithType("C"));
+ }
+ {
+ static const char *DT[] = {"A:3", "B:", "C"};
+ setCurrentDebugTypes(DT, sizeof(DT) / sizeof(DT[0]));
+ EXPECT_TRUE(CheckDebugWithType("A"));
+ EXPECT_FALSE(isCurrentDebugType("A", 4));
+ EXPECT_FALSE(CheckDebugWithType("B"));
+ EXPECT_TRUE(isCurrentDebugType("C", 10));
+ EXPECT_FALSE(CheckDebugWithType("D"));
+ }
+}
#endif
More information about the llvm-commits
mailing list