[llvm] [DAG] Generalize fold (not (neg x)) -> (add X, -1) (PR #154348)

[Matt Arsenault via llvm-commits]

================
@@ -9988,13 +9988,14 @@ SDValue DAGCombiner::visitXOR(SDNode *N) {
     }
   }
 
-  // fold (not (neg x)) -> (add X, -1)
-  // FIXME: This can be generalized to (not (sub Y, X)) -> (add X, ~Y) if
-  // Y is a constant or the subtract has a single use.
-  if (isAllOnesConstant(N1) && N0.getOpcode() == ISD::SUB &&
-      isNullConstant(N0.getOperand(0))) {
-    return DAG.getNode(ISD::ADD, DL, VT, N0.getOperand(1),
-                       DAG.getAllOnesConstant(DL, VT));
+  // fold (not (sub Y, X)) -> (add X, ~Y) if Y is a constant or the subtract has a single use.
+  if (isAllOnesConstant(N1) && N0.getOpcode() == ISD::SUB) {
+    SDValue Y = N0.getOperand(0);
+    SDValue X = N0.getOperand(1);
+    if (isa<ConstantSDNode>(Y) || N0.hasOneUse()) {
+      SDValue NotY = DAG.getNode(ISD::XOR, DL, VT, Y, DAG.getAllOnesConstant(DL, VT));
----------------
arsenm wrote:

N1 is already isAllOnesConstant 

https://github.com/llvm/llvm-project/pull/154348