[compiler-rt] [Sanitizers][Test] narrower constraint for XFAIL (PR #154245)

Mariusz Borsa via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 18 18:10:35 PDT 2025


https://github.com/wrotki created https://github.com/llvm/llvm-project/pull/154245

It's a followup to https://github.com/llvm/llvm-project/pull/154189 ,
which broke test on android bot. Making sure XFAIL only happen on darwin
bots

rdar://158543555


>From d1d2d9634ee7acb6b1c287c5c70ecc0c32dc840c Mon Sep 17 00:00:00 2001
From: Mariusz Borsa <m_borsa at apple.com>
Date: Mon, 18 Aug 2025 17:54:46 -0700
Subject: [PATCH] [Sanitizers][Test] narrower constraint for XFAIL

It's a followup to https://github.com/llvm/llvm-project/pull/154189 ,
which broke test on android bot. Making sure XFAIL only happen on darwin
bots

rdar://158543555
---
 compiler-rt/test/asan/TestCases/Darwin/suppressions-sandbox.cpp | 2 +-
 compiler-rt/test/asan/TestCases/Posix/fread_fwrite.cpp          | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/compiler-rt/test/asan/TestCases/Darwin/suppressions-sandbox.cpp b/compiler-rt/test/asan/TestCases/Darwin/suppressions-sandbox.cpp
index fc1da56a969df..f12e2b2ada50d 100644
--- a/compiler-rt/test/asan/TestCases/Darwin/suppressions-sandbox.cpp
+++ b/compiler-rt/test/asan/TestCases/Darwin/suppressions-sandbox.cpp
@@ -16,7 +16,7 @@
 // UNSUPPORTED: ios
 
 // Symbolizer fails to find test functions on current macOS bot version
-// XFAIL: target=arm{{.*}}
+// XFAIL: system-darwin && target=arm{{.*}}
 
 #include <CoreFoundation/CoreFoundation.h>
 
diff --git a/compiler-rt/test/asan/TestCases/Posix/fread_fwrite.cpp b/compiler-rt/test/asan/TestCases/Posix/fread_fwrite.cpp
index 5f0be27a36318..c7b9280ea7d8e 100644
--- a/compiler-rt/test/asan/TestCases/Posix/fread_fwrite.cpp
+++ b/compiler-rt/test/asan/TestCases/Posix/fread_fwrite.cpp
@@ -3,7 +3,7 @@
 // RUN: not %run %t 1 2>&1 | FileCheck %s --check-prefix=CHECK-FREAD
 
 // Symbolizer fails to find test functions on current macOS bot version
-// XFAIL: target=arm{{.*}}
+// XFAIL: system-darwin && target=arm{{.*}}
 
 #include <stdio.h>
 #include <stdlib.h>



More information about the llvm-commits mailing list