[llvm] [Github] Simplify Getting Changed Files in Code Formatting Workflow (PR #133023)
Baranov Victor via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 18 12:49:16 PDT 2025
================
@@ -89,8 +84,8 @@ jobs:
--write-comment-to-file \
--token ${{ secrets.GITHUB_TOKEN }} \
--issue-number $GITHUB_PR_NUMBER \
- --start-rev $(git merge-base $START_REV $END_REV) \
- --end-rev $END_REV \
+ --start-rev HEAD~1 \
+ --end-rev HEAD \
----------------
vbvictor wrote:
Thank you! I guess in my local runs I have slightly different setup.
> Anything clang-tidy should also probably be integrated into the code format job. Using a separate job means we need extra things like an additional clone of LLVM every time.
I'm afraid that code formatting job will become too bloated with all these changes.
For `clang-tidy` CI, we need to additionally `cmake configure`, `ninja build tablegen` and `run clang-tidy`. I'll look into integration with formatting job.
https://github.com/llvm/llvm-project/pull/133023
More information about the llvm-commits
mailing list