[llvm] [ADT] Use range-based for loops in SetVector (NFC) (PR #154058)

Kazu Hirata via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 17 21:24:33 PDT 2025


https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/154058

None

>From 25a71b70ab4e89e3a875981304d59da422ad9b99 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Sun, 17 Aug 2025 19:57:43 -0700
Subject: [PATCH] [ADT] Use range-based for loops in SetVector (NFC)

---
 llvm/include/llvm/ADT/SetVector.h | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/llvm/include/llvm/ADT/SetVector.h b/llvm/include/llvm/ADT/SetVector.h
index 0692071adb391..85d4f2d5ee28a 100644
--- a/llvm/include/llvm/ADT/SetVector.h
+++ b/llvm/include/llvm/ADT/SetVector.h
@@ -313,9 +313,8 @@ class SetVector {
   bool set_union(const STy &S) {
     bool Changed = false;
 
-    for (typename STy::const_iterator SI = S.begin(), SE = S.end(); SI != SE;
-         ++SI)
-      if (insert(*SI))
+    for (const auto &Elem : S)
+      if (insert(Elem))
         Changed = true;
 
     return Changed;
@@ -326,9 +325,8 @@ class SetVector {
   ///       SetVector interface is inconsistent with DenseSet.
   template <class STy>
   void set_subtract(const STy &S) {
-    for (typename STy::const_iterator SI = S.begin(), SE = S.end(); SI != SE;
-         ++SI)
-      remove(*SI);
+    for (const auto &Elem : S)
+      remove(Elem);
   }
 
   void swap(SetVector<T, Vector, Set, N> &RHS) {



More information about the llvm-commits mailing list