[llvm] 2cedb28 - MCSymbol: Remove unused IsTarget parameter from declareCommon
Fangrui Song via llvm-commits
llvm-commits at lists.llvm.org
Sat Aug 16 15:47:44 PDT 2025
Author: Fangrui Song
Date: 2025-08-16T15:47:39-07:00
New Revision: 2cedb286b8a37a3c6f09ac394b5e95413baac287
URL: https://github.com/llvm/llvm-project/commit/2cedb286b8a37a3c6f09ac394b5e95413baac287
DIFF: https://github.com/llvm/llvm-project/commit/2cedb286b8a37a3c6f09ac394b5e95413baac287.diff
LOG: MCSymbol: Remove unused IsTarget parameter from declareCommon
Added:
Modified:
llvm/include/llvm/MC/MCSymbol.h
llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp
Removed:
################################################################################
diff --git a/llvm/include/llvm/MC/MCSymbol.h b/llvm/include/llvm/MC/MCSymbol.h
index 88e2230a0c340..13d74157bc018 100644
--- a/llvm/include/llvm/MC/MCSymbol.h
+++ b/llvm/include/llvm/MC/MCSymbol.h
@@ -311,7 +311,7 @@ class MCSymbol {
/// \param Size - The size of the symbol.
/// \param Alignment - The alignment of the symbol.
/// \param Target - Is the symbol a target-specific common-like symbol.
- void setCommon(uint64_t Size, Align Alignment, bool Target = false) {
+ void setCommon(uint64_t Size, Align Alignment) {
assert(getOffset() == 0);
CommonSize = Size;
kind = Kind::Common;
@@ -332,15 +332,14 @@ class MCSymbol {
///
/// \param Size - The size of the symbol.
/// \param Alignment - The alignment of the symbol.
- /// \param Target - Is the symbol a target-specific common-like symbol.
/// \return True if symbol was already declared as a
diff erent type
- bool declareCommon(uint64_t Size, Align Alignment, bool Target = false) {
+ bool declareCommon(uint64_t Size, Align Alignment) {
assert(isCommon() || getOffset() == 0);
if(isCommon()) {
if (CommonSize != Size || getCommonAlignment() != Alignment)
return true;
} else
- setCommon(Size, Alignment, Target);
+ setCommon(Size, Alignment);
return false;
}
diff --git a/llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp b/llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp
index 1f35e92151bfc..f000b2cc60c92 100644
--- a/llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp
+++ b/llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp
@@ -886,7 +886,7 @@ void AMDGPUTargetELFStreamer::emitAMDGPULDS(MCSymbol *Symbol, unsigned Size,
if (!SymbolELF->isBindingSet())
SymbolELF->setBinding(ELF::STB_GLOBAL);
- if (SymbolELF->declareCommon(Size, Alignment, true)) {
+ if (SymbolELF->declareCommon(Size, Alignment)) {
report_fatal_error("Symbol: " + Symbol->getName() +
" redeclared as
diff erent type");
}
More information about the llvm-commits
mailing list