[llvm] [AMDGPU] gfx1250 does not need nop before VGPR dealloc (PR #153844)

Stanislav Mekhanoshin via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 15 10:46:15 PDT 2025


https://github.com/rampitec created https://github.com/llvm/llvm-project/pull/153844

This has no impact as the dealloc is now practically disabled.

>From 0b98a5637a122595a8570178e8b4bc6c49b71c00 Mon Sep 17 00:00:00 2001
From: Stanislav Mekhanoshin <Stanislav.Mekhanoshin at amd.com>
Date: Fri, 15 Aug 2025 10:45:04 -0700
Subject: [PATCH] [AMDGPU] gfx1250 does not need nop before VGPR dealloc

This has no impact as the dealloc is now practically disabled.
---
 llvm/lib/Target/AMDGPU/GCNSubtarget.h | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/llvm/lib/Target/AMDGPU/GCNSubtarget.h b/llvm/lib/Target/AMDGPU/GCNSubtarget.h
index f9f512bad13ad..2ad83c90dc209 100644
--- a/llvm/lib/Target/AMDGPU/GCNSubtarget.h
+++ b/llvm/lib/Target/AMDGPU/GCNSubtarget.h
@@ -1799,11 +1799,7 @@ class GCNSubtarget final : public AMDGPUGenSubtargetInfo,
 
   // \returns true if the subtarget has a hazard requiring an "s_nop 0"
   // instruction before "s_sendmsg sendmsg(MSG_DEALLOC_VGPRS)".
-  bool requiresNopBeforeDeallocVGPRs() const {
-    // Currently all targets that support the dealloc VGPRs message also require
-    // the nop.
-    return true;
-  }
+  bool requiresNopBeforeDeallocVGPRs() const { return !GFX1250Insts; }
 
   bool isDynamicVGPREnabled() const { return DynamicVGPR; }
   unsigned getDynamicVGPRBlockSize() const {



More information about the llvm-commits mailing list