[llvm] [LegacyPM][CGSCC] Print banner with newline when filter-print-funcs is given. (PR #153699)
Andy Kaylor via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 15 09:53:08 PDT 2025
================
@@ -701,12 +700,11 @@ namespace {
}
} else if (isFunctionInPrintList("*")) {
PrintBannerOnce();
- OS << "\nPrinting <null> Function\n";
+ OS << "Printing <null> Function\n";
----------------
andykaylor wrote:
I don't have a strong preference either, but I like whitespace between IR and banners. What I'm picture is this:
```
*** IR Dump After Function Integration/Inlining (inline) ***
Printing <null> Function
; Function attrs:
define @foo() {
...
}
Printing <null> Function
; Function attrs:
define @bar() {
...
}
*** IR Dump After ... ***
```
versus this:
```
*** IR Dump After Function Integration/Inlining (inline) ***
Printing <null> Function
; Function attrs:
define @foo() {
...
}
Printing <null> Function
; Function attrs:
define @bar() {
...
}
*** IR Dump After ... ***
```
I'd prefer the former, but without running a dump I'm not sure I've even pictured it correctly.
https://github.com/llvm/llvm-project/pull/153699
More information about the llvm-commits
mailing list