[llvm] [NFC][PGO] Factor downscaling of branch weights out of `Instrumentation` into `ProfileData` (PR #153735)

Thu Aug 14 22:48:49 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-hip-vega20` running on `hip-vega20-0` while building `llvm` at step 3 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/123/builds/25270

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 3 (annotate) failure: '../llvm-zorg/zorg/buildbot/builders/annotated/hip-build.sh --jobs=' (failure)
...
[1241/5225] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MIRPrinter.cpp.o
[1242/5225] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MacroFusion.cpp.o
[1243/5225] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/OptimizePHIs.cpp.o
[1244/5225] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/PeepholeOptimizer.cpp.o
[1245/5225] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/PHIElimination.cpp.o
[1246/5225] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/PostRAHazardRecognizer.cpp.o
[1247/5225] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/PHIEliminationUtils.cpp.o
[1248/5225] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/PostRASchedulerList.cpp.o
[1249/5225] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/PseudoProbeInserter.cpp.o
[1250/5225] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/ProfDataUtils.cpp.o
FAILED: lib/IR/CMakeFiles/LLVMCore.dir/ProfDataUtils.cpp.o 
ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/botworker/bbot/clang-hip-vega20/botworker/clang-hip-vega20/llvm/lib/IR -I/home/botworker/bbot/clang-hip-vega20/llvm-project/llvm/lib/IR -I/home/botworker/bbot/clang-hip-vega20/botworker/clang-hip-vega20/llvm/include -I/home/botworker/bbot/clang-hip-vega20/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT lib/IR/CMakeFiles/LLVMCore.dir/ProfDataUtils.cpp.o -MF lib/IR/CMakeFiles/LLVMCore.dir/ProfDataUtils.cpp.o.d -o lib/IR/CMakeFiles/LLVMCore.dir/ProfDataUtils.cpp.o -c /home/botworker/bbot/clang-hip-vega20/llvm-project/llvm/lib/IR/ProfDataUtils.cpp
/home/botworker/bbot/clang-hip-vega20/llvm-project/llvm/lib/IR/ProfDataUtils.cpp: In function ‘llvm::SmallVector<unsigned int> llvm::downscaleWeights(llvm::ArrayRef<long unsigned int>, std::optional<long unsigned int>)’:
/home/botworker/bbot/clang-hip-vega20/llvm-project/llvm/lib/IR/ProfDataUtils.cpp:282:10: error: could not convert ‘DownscaledWeights’ from ‘SmallVector<[...],4>’ to ‘SmallVector<[...],12>’
  282 |   return DownscaledWeights;
      |          ^~~~~~~~~~~~~~~~~
      |          |
      |          SmallVector<[...],4>
[1251/5225] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/PrologEpilogInserter.cpp.o
[1252/5225] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/PreISelIntrinsicLowering.cpp.o
[1253/5225] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/ProcessImplicitDefs.cpp.o
[1254/5225] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/PseudoSourceValue.cpp.o
[1255/5225] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/MDBuilder.cpp.o
[1256/5225] Building X86GenFastISel.inc...
[1257/5225] Building X86GenDAGISel.inc...
[1258/5225] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Function.cpp.o
[1259/5225] Building X86GenGlobalISel.inc...
[1260/5225] Building X86GenSubtargetInfo.inc...
[1261/5225] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Instruction.cpp.o
[1262/5225] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineCFGPrinter.cpp.o
[1263/5225] Building X86GenInstrInfo.inc...
[1264/5225] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Instructions.cpp.o
[1265/5225] Building AMDGPUGenMCPseudoLowering.inc...
[1266/5225] Building AMDGPUGenRegBankGICombiner.inc...
[1267/5225] Building AMDGPUGenPostLegalizeGICombiner.inc...
[1268/5225] Building AMDGPUGenPreLegalizeGICombiner.inc...
[1269/5225] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Verifier.cpp.o
[1270/5225] Building AMDGPUGenDisassemblerTables.inc...
[1271/5225] Building AMDGPUGenSubtargetInfo.inc...
[1272/5225] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Metadata.cpp.o
[1273/5225] Building AMDGPUGenMCCodeEmitter.inc...
[1274/5225] Building AMDGPUGenSearchableTables.inc...
[1275/5225] Building AMDGPUGenCallingConv.inc...
[1276/5225] Building AMDGPUGenAsmWriter.inc...
[1277/5225] Building AMDGPUGenGlobalISel.inc...
[1278/5225] Building AMDGPUGenAsmMatcher.inc...
[1279/5225] Building AMDGPUGenDAGISel.inc...
[1280/5225] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/CodeGenPrepare.cpp.o
[1281/5225] Building AMDGPUGenInstrInfo.inc...
Step 7 (Building LLVM) failure: Building LLVM (failure)
...
[1241/5225] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MIRPrinter.cpp.o
[1242/5225] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MacroFusion.cpp.o
[1243/5225] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/OptimizePHIs.cpp.o
[1244/5225] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/PeepholeOptimizer.cpp.o
[1245/5225] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/PHIElimination.cpp.o
[1246/5225] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/PostRAHazardRecognizer.cpp.o
[1247/5225] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/PHIEliminationUtils.cpp.o
[1248/5225] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/PostRASchedulerList.cpp.o
[1249/5225] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/PseudoProbeInserter.cpp.o
[1250/5225] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/ProfDataUtils.cpp.o
FAILED: lib/IR/CMakeFiles/LLVMCore.dir/ProfDataUtils.cpp.o 
ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/botworker/bbot/clang-hip-vega20/botworker/clang-hip-vega20/llvm/lib/IR -I/home/botworker/bbot/clang-hip-vega20/llvm-project/llvm/lib/IR -I/home/botworker/bbot/clang-hip-vega20/botworker/clang-hip-vega20/llvm/include -I/home/botworker/bbot/clang-hip-vega20/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT lib/IR/CMakeFiles/LLVMCore.dir/ProfDataUtils.cpp.o -MF lib/IR/CMakeFiles/LLVMCore.dir/ProfDataUtils.cpp.o.d -o lib/IR/CMakeFiles/LLVMCore.dir/ProfDataUtils.cpp.o -c /home/botworker/bbot/clang-hip-vega20/llvm-project/llvm/lib/IR/ProfDataUtils.cpp
/home/botworker/bbot/clang-hip-vega20/llvm-project/llvm/lib/IR/ProfDataUtils.cpp: In function ‘llvm::SmallVector<unsigned int> llvm::downscaleWeights(llvm::ArrayRef<long unsigned int>, std::optional<long unsigned int>)’:
/home/botworker/bbot/clang-hip-vega20/llvm-project/llvm/lib/IR/ProfDataUtils.cpp:282:10: error: could not convert ‘DownscaledWeights’ from ‘SmallVector<[...],4>’ to ‘SmallVector<[...],12>’
  282 |   return DownscaledWeights;
      |          ^~~~~~~~~~~~~~~~~
      |          |
      |          SmallVector<[...],4>
[1251/5225] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/PrologEpilogInserter.cpp.o
[1252/5225] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/PreISelIntrinsicLowering.cpp.o
[1253/5225] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/ProcessImplicitDefs.cpp.o
[1254/5225] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/PseudoSourceValue.cpp.o
[1255/5225] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/MDBuilder.cpp.o
[1256/5225] Building X86GenFastISel.inc...
[1257/5225] Building X86GenDAGISel.inc...
[1258/5225] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Function.cpp.o
[1259/5225] Building X86GenGlobalISel.inc...
[1260/5225] Building X86GenSubtargetInfo.inc...
[1261/5225] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Instruction.cpp.o
[1262/5225] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineCFGPrinter.cpp.o
[1263/5225] Building X86GenInstrInfo.inc...
[1264/5225] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Instructions.cpp.o
[1265/5225] Building AMDGPUGenMCPseudoLowering.inc...
[1266/5225] Building AMDGPUGenRegBankGICombiner.inc...
[1267/5225] Building AMDGPUGenPostLegalizeGICombiner.inc...
[1268/5225] Building AMDGPUGenPreLegalizeGICombiner.inc...
[1269/5225] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Verifier.cpp.o
[1270/5225] Building AMDGPUGenDisassemblerTables.inc...
[1271/5225] Building AMDGPUGenSubtargetInfo.inc...
[1272/5225] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Metadata.cpp.o
[1273/5225] Building AMDGPUGenMCCodeEmitter.inc...
[1274/5225] Building AMDGPUGenSearchableTables.inc...
[1275/5225] Building AMDGPUGenCallingConv.inc...
[1276/5225] Building AMDGPUGenAsmWriter.inc...
[1277/5225] Building AMDGPUGenGlobalISel.inc...
[1278/5225] Building AMDGPUGenAsmMatcher.inc...
[1279/5225] Building AMDGPUGenDAGISel.inc...
[1280/5225] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/CodeGenPrepare.cpp.o
[1281/5225] Building AMDGPUGenInstrInfo.inc...

```

</details>

https://github.com/llvm/llvm-project/pull/153735