[llvm] [NFC][PGO] Factor downscaling of branch weights out of `Instrumentation` into `ProfileData` (PR #153735)

Thu Aug 14 22:47:14 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `openmp-offload-amdgpu-runtime-2` running on `rocm-worker-hw-02` while building `llvm` at step 5 "compile-openmp".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/10/builds/11471

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (compile-openmp) failure: build (failure)
...
3.253 [2799/64/1841] Building CXX object lib/Transforms/Scalar/CMakeFiles/LLVMScalarOpts.dir/InstSimplifyPass.cpp.o
3.262 [2798/64/1842] Building CXX object lib/Transforms/Scalar/CMakeFiles/LLVMScalarOpts.dir/LICM.cpp.o
3.263 [2797/64/1843] Building CXX object lib/Transforms/Scalar/CMakeFiles/LLVMScalarOpts.dir/LoopAccessAnalysisPrinter.cpp.o
3.274 [2796/64/1844] Building CXX object lib/Transforms/Scalar/CMakeFiles/LLVMScalarOpts.dir/LoopBoundSplit.cpp.o
3.274 [2795/64/1845] Building CXX object lib/Transforms/Scalar/CMakeFiles/LLVMScalarOpts.dir/LoopSink.cpp.o
3.286 [2794/64/1846] Building CXX object lib/Transforms/Scalar/CMakeFiles/LLVMScalarOpts.dir/LoopDeletion.cpp.o
3.287 [2793/64/1847] Building CXX object lib/Transforms/Scalar/CMakeFiles/LLVMScalarOpts.dir/LoopDataPrefetch.cpp.o
3.298 [2792/64/1848] Building CXX object lib/Transforms/Scalar/CMakeFiles/LLVMScalarOpts.dir/LoopDistribute.cpp.o
3.298 [2791/64/1849] Building CXX object lib/Transforms/Scalar/CMakeFiles/LLVMScalarOpts.dir/LoopFuse.cpp.o
3.302 [2790/64/1850] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/ProfDataUtils.cpp.o
FAILED: lib/IR/CMakeFiles/LLVMCore.dir/ProfDataUtils.cpp.o 
ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -DLLVM_EXPORTS -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/lib/IR -I/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/llvm/lib/IR -I/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/include -I/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -fPIC  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT lib/IR/CMakeFiles/LLVMCore.dir/ProfDataUtils.cpp.o -MF lib/IR/CMakeFiles/LLVMCore.dir/ProfDataUtils.cpp.o.d -o lib/IR/CMakeFiles/LLVMCore.dir/ProfDataUtils.cpp.o -c /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/llvm/lib/IR/ProfDataUtils.cpp
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/llvm/lib/IR/ProfDataUtils.cpp: In function ‘llvm::SmallVector<unsigned int> llvm::downscaleWeights(llvm::ArrayRef<long unsigned int>, std::optional<long unsigned int>)’:
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/llvm/lib/IR/ProfDataUtils.cpp:282:10: error: could not convert ‘DownscaledWeights’ from ‘SmallVector<[...],4>’ to ‘SmallVector<[...],12>’
  282 |   return DownscaledWeights;
      |          ^~~~~~~~~~~~~~~~~
      |          |
      |          SmallVector<[...],4>
3.310 [2790/63/1851] Building CXX object lib/Transforms/Scalar/CMakeFiles/LLVMScalarOpts.dir/LoopInstSimplify.cpp.o
3.310 [2790/62/1852] Building CXX object lib/Transforms/Scalar/CMakeFiles/LLVMScalarOpts.dir/LoopIdiomRecognize.cpp.o
3.452 [2790/61/1853] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/MDBuilder.cpp.o
4.077 [2790/60/1854] Building X86GenFastISel.inc...
4.223 [2790/59/1855] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/MisExpect.cpp.o
4.393 [2790/58/1856] Building X86GenGlobalISel.inc...
4.462 [2790/57/1857] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/ProfileVerify.cpp.o
4.672 [2790/56/1858] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/Instrumentation.cpp.o
4.784 [2790/55/1859] Building X86GenSubtargetInfo.inc...
4.846 [2790/54/1860] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Function.cpp.o
4.877 [2790/53/1861] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineCFGPrinter.cpp.o
5.107 [2790/52/1862] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/SanitizerBinaryMetadata.cpp.o
5.124 [2790/51/1863] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Instruction.cpp.o
5.207 [2790/50/1864] Building X86GenDAGISel.inc...
5.506 [2790/49/1865] Building CXX object lib/Transforms/Instrumentation/CMakeFiles/LLVMInstrumentation.dir/CGProfile.cpp.o
5.950 [2790/48/1866] Building CXX object lib/Transforms/Instrumentation/CMakeFiles/LLVMInstrumentation.dir/SanitizerBinaryMetadata.cpp.o
6.299 [2790/47/1867] Building X86GenInstrInfo.inc...
6.517 [2790/46/1868] Building CXX object lib/Transforms/Instrumentation/CMakeFiles/LLVMInstrumentation.dir/SanitizerCoverage.cpp.o
6.562 [2790/45/1869] Building CXX object lib/Transforms/Instrumentation/CMakeFiles/LLVMInstrumentation.dir/ThreadSanitizer.cpp.o
6.662 [2790/44/1870] Building CXX object lib/Transforms/Instrumentation/CMakeFiles/LLVMInstrumentation.dir/NumericalStabilitySanitizer.cpp.o
6.668 [2790/43/1871] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/LoopRotationUtils.cpp.o
6.833 [2790/42/1872] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Instructions.cpp.o
6.929 [2790/41/1873] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/LoopUnrollRuntime.cpp.o
6.937 [2790/40/1874] Building CXX object lib/Transforms/Scalar/CMakeFiles/LLVMScalarOpts.dir/JumpTableToSwitch.cpp.o
7.196 [2790/39/1875] Building CXX object lib/MC/MCParser/CMakeFiles/LLVMMCParser.dir/AsmParser.cpp.o
7.300 [2790/38/1876] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/LoopPeel.cpp.o
7.409 [2790/37/1877] Building CXX object tools/opt/CMakeFiles/obj.LLVMOptDriver.dir/optdriver.cpp.o
7.664 [2790/36/1878] Building CXX object lib/Transforms/Instrumentation/CMakeFiles/LLVMInstrumentation.dir/GCOVProfiling.cpp.o
7.933 [2790/35/1879] Building CXX object lib/Transforms/Instrumentation/CMakeFiles/LLVMInstrumentation.dir/IndirectCallPromotion.cpp.o
7.961 [2790/34/1880] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/SelectOptimize.cpp.o
8.028 [2790/33/1881] Building CXX object lib/Transforms/Instrumentation/CMakeFiles/LLVMInstrumentation.dir/InstrProfiling.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/153735