[llvm] Revert "[CI] Make email check workflow fail when author's email is private in Github UI" (PR #149186)

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 13 12:56:27 PDT 2025


mstorsjo wrote:

> One possible option is to get the commit when PR gets merged, get the email associated with the commit, and if it's `noreply.github` then we drop a comment to the PR about using private email. But, this approach is post-commit and does not prevent users from merging a PR with `noreply.github` email, still it is better than what we have currently.

Thanks, that sounds like a good idea - certainly better than doing nothing (or having to manually comment about it when encountering it)! It doesn't get the rate of noreply email addresses down to zero, but it should converge towards valid emails for each individual contributor, ideally.

> Also, at https://github.com/intel/llvm, we have a policy for gatekeepers (folks with merge rights) to double-check the email id before merging a PR and in the past, this has worked pretty good for us. Maybe we can adopt a similar policy for https://github.com/llvm/llvm-project ?

Like just a bullet point in docs for your development practices? I guess we could add that as well - not sure how much practical effect that has (if people would notice the added documentation and pick up on doing it), but I guess it's better than nothing as well.

https://github.com/llvm/llvm-project/pull/149186


More information about the llvm-commits mailing list