[llvm] [Dexter][NFC] Rename step -> step_in (PR #152716)

Orlando Cazalet-Hyams via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 11 08:58:19 PDT 2025


https://github.com/OCHyams updated https://github.com/llvm/llvm-project/pull/152716

>From a963080f3d62833b646fcbb73433d4c39069183d Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams <orlando.hyams at sony.com>
Date: Thu, 7 Aug 2025 11:53:40 +0100
Subject: [PATCH] [Dexter][NFC] Rename step -> step_in

---
 .../debuginfo-tests/dexter/dex/debugger/DAP.py                | 2 +-
 .../debuginfo-tests/dexter/dex/debugger/DebuggerBase.py       | 2 +-
 .../dex/debugger/DebuggerControllers/DefaultController.py     | 2 +-
 .../debuginfo-tests/dexter/dex/debugger/dbgeng/dbgeng.py      | 4 ++--
 .../debuginfo-tests/dexter/dex/debugger/lldb/LLDB.py          | 2 +-
 .../dexter/dex/debugger/visualstudio/VisualStudio.py          | 2 +-
 6 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/cross-project-tests/debuginfo-tests/dexter/dex/debugger/DAP.py b/cross-project-tests/debuginfo-tests/dexter/dex/debugger/DAP.py
index 76aa4286a5528..3921e7f407f06 100644
--- a/cross-project-tests/debuginfo-tests/dexter/dex/debugger/DAP.py
+++ b/cross-project-tests/debuginfo-tests/dexter/dex/debugger/DAP.py
@@ -635,7 +635,7 @@ def launch(self, cmdline):
     def _post_step_hook(self):
         """Hook to be executed after completing a step request."""
 
-    def step(self):
+    def step_in(self):
         self._flush_breakpoints()
         step_req_id = self.send_message(
             self.make_request("stepIn", {"threadId": self._debugger_state.thread})
diff --git a/cross-project-tests/debuginfo-tests/dexter/dex/debugger/DebuggerBase.py b/cross-project-tests/debuginfo-tests/dexter/dex/debugger/DebuggerBase.py
index d4a555085face..bf7552bd5fe3a 100644
--- a/cross-project-tests/debuginfo-tests/dexter/dex/debugger/DebuggerBase.py
+++ b/cross-project-tests/debuginfo-tests/dexter/dex/debugger/DebuggerBase.py
@@ -184,7 +184,7 @@ def launch(self):
         pass
 
     @abc.abstractmethod
-    def step(self):
+    def step_in(self):
         pass
 
     @abc.abstractmethod
diff --git a/cross-project-tests/debuginfo-tests/dexter/dex/debugger/DebuggerControllers/DefaultController.py b/cross-project-tests/debuginfo-tests/dexter/dex/debugger/DebuggerControllers/DefaultController.py
index 709bd76e2050c..14270843822f3 100644
--- a/cross-project-tests/debuginfo-tests/dexter/dex/debugger/DebuggerControllers/DefaultController.py
+++ b/cross-project-tests/debuginfo-tests/dexter/dex/debugger/DebuggerControllers/DefaultController.py
@@ -128,7 +128,7 @@ def _run_debugger_custom(self, cmdline):
                     break
 
             if in_source_file(self.source_files, step_info):
-                self.debugger.step()
+                self.debugger.step_in()
             else:
                 self.debugger.go()
 
diff --git a/cross-project-tests/debuginfo-tests/dexter/dex/debugger/dbgeng/dbgeng.py b/cross-project-tests/debuginfo-tests/dexter/dex/debugger/dbgeng/dbgeng.py
index 03aa548495ce1..bf0a0f1986721 100644
--- a/cross-project-tests/debuginfo-tests/dexter/dex/debugger/dbgeng/dbgeng.py
+++ b/cross-project-tests/debuginfo-tests/dexter/dex/debugger/dbgeng/dbgeng.py
@@ -111,7 +111,7 @@ def launch(self, cmdline):
         # We are, by this point, already launched.
         self.step_info = probe_process.probe_state(self.client)
 
-    def step(self):
+    def step_in(self):
         res = setup.step_once(self.client)
         if not res:
             self.finished = True
@@ -122,7 +122,7 @@ def go(self):
         # relevant source file -- this is likely to be a problem when setting
         # breakpoints. Until that's fixed, single step instead of running
         # freely. This isn't very efficient, but at least makes progress.
-        self.step()
+        self.step_in()
 
     def _get_step_info(self, watches, step_index):
         frames = self.step_info
diff --git a/cross-project-tests/debuginfo-tests/dexter/dex/debugger/lldb/LLDB.py b/cross-project-tests/debuginfo-tests/dexter/dex/debugger/lldb/LLDB.py
index 2cf9553940751..4263fdb5aa019 100644
--- a/cross-project-tests/debuginfo-tests/dexter/dex/debugger/lldb/LLDB.py
+++ b/cross-project-tests/debuginfo-tests/dexter/dex/debugger/lldb/LLDB.py
@@ -204,7 +204,7 @@ def launch(self, cmdline):
         assert num_stopped_threads > 0
         assert self._thread, (self._process, self._thread)
 
-    def step(self):
+    def step_in(self):
         self._thread.StepInto()
         stop_reason = self._thread.GetStopReason()
         # If we (1) completed a step and (2) are sitting at a breakpoint,
diff --git a/cross-project-tests/debuginfo-tests/dexter/dex/debugger/visualstudio/VisualStudio.py b/cross-project-tests/debuginfo-tests/dexter/dex/debugger/visualstudio/VisualStudio.py
index a7f12cde1f047..1a1c8e9a8d9aa 100644
--- a/cross-project-tests/debuginfo-tests/dexter/dex/debugger/visualstudio/VisualStudio.py
+++ b/cross-project-tests/debuginfo-tests/dexter/dex/debugger/visualstudio/VisualStudio.py
@@ -308,7 +308,7 @@ def launch(self, cmdline):
         self.context.logger.note("Launching VS debugger...")
         self._fn_go(False)
 
-    def step(self):
+    def step_in(self):
         self._fn_step(False)
 
     def go(self) -> ReturnCode:



More information about the llvm-commits mailing list