[llvm] [LLVM][IR] Switch from manual pointer incrementation to function in Lexer (PR #152103)

[Nikita Popov via llvm-commits]

Albert =?utf-8?q?Havliček?= <ahavlicek at azul.com>,
Albert =?utf-8?q?Havliček?= <ahavlicek at azul.com>,
Albert =?utf-8?q?Havliček?= <ahavlicek at azul.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/152103 at github.com>


https://github.com/nikic commented:

Can you please explain the motivation for making everything go through getNextChar()? The discourse thread mentions that this is somehow LSP related, but it's not obvious to me how.

Using getNextChar() instead of incrementing CurPtr seems reasonable enough, I'm more curious about things like advancePositionTo which now do a byte-wise advance instead of the obvious thing.

https://github.com/llvm/llvm-project/pull/152103