[llvm] [LLVM][Coverage][Unittest] Fix dangling reference in unittest (PR #147118)

[Martin Storsjö via llvm-commits]

mstorsjo wrote:

> Gentle ping. This causes the test to fail unexpectedly on Cygwin, which uses old CoW `std::string`.

The fix looks reasonable, but I wonder why this issue hasn't been observed elsewhere. If I understand it correctly, this issue should be observable anywhere by building and running this unit test with address sanitizer, no? Or does it specifically require having the old libstdc++ CoW `std::string` implementation in order to observe the issue?

If the issue is having an `ArrayRef()` pointing to an `std::vector<std::string>` which has been cleared, it sounds to me like it indeed would be observeable anywhere.


https://github.com/llvm/llvm-project/pull/147118