[llvm] [TTI] Consistently pass the pointer type to getAddressComputationCost. NFCI (PR #152657)

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 11 01:49:40 PDT 2025


================
@@ -1675,13 +1675,14 @@ class TargetTransformInfo {
 
   /// \returns The cost of the address computation. For most targets this can be
   /// merged into the instruction indexing mode. Some targets might want to
-  /// distinguish between address computation for memory operations on vector
-  /// types and scalar types. Such targets should override this function.
-  /// The 'SE' parameter holds pointer for the scalar evolution object which
-  /// is used in order to get the Ptr step value in case of constant stride.
-  /// The 'Ptr' parameter holds SCEV of the access pointer.
-  LLVM_ABI InstructionCost getAddressComputationCost(
-      Type *Ty, ScalarEvolution *SE = nullptr, const SCEV *Ptr = nullptr) const;
+  /// distinguish between address computation for memory operations with vector
+  /// pointer types and scalar pointer types. Such targets should override this
+  /// function. \p SE holds the pointer for the scalar evolution object which is
+  /// used in order to get the Ptr step value in case of constant stride. \p Ptr
----------------
fhahn wrote:

nit:
```suggestion
  /// used in order to get the Ptr step value. \p Ptr
```

The existing wording makes it sound like this is only used if Ptr has a constant stride, but SE and Ptr are used to check if Ptr has a constant stride?

Also, there are no vector SCEVs, is `Ptr` only used for scalar pointers or the lane 0 address?

https://github.com/llvm/llvm-project/pull/152657


More information about the llvm-commits mailing list