[llvm] [Offload] Fix olWaitEvents tests after change to events API (PR #150465)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 24 10:06:23 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-offload
Author: Callum Fare (callumfare)
<details>
<summary>Changes</summary>
Fix the olWaitEvents tests after #<!-- -->150217 broke them
---
Full diff: https://github.com/llvm/llvm-project/pull/150465.diff
1 Files Affected:
- (modified) offload/unittests/OffloadAPI/queue/olWaitEvents.cpp (+6-3)
``````````diff
diff --git a/offload/unittests/OffloadAPI/queue/olWaitEvents.cpp b/offload/unittests/OffloadAPI/queue/olWaitEvents.cpp
index c1e9acd1797d8..9838562752cc4 100644
--- a/offload/unittests/OffloadAPI/queue/olWaitEvents.cpp
+++ b/offload/unittests/OffloadAPI/queue/olWaitEvents.cpp
@@ -52,7 +52,8 @@ TEST_P(olWaitEventsTest, Success) {
ASSERT_SUCCESS(olWaitEvents(Queues[I], &Events[I - 1], 1));
ASSERT_SUCCESS(olLaunchKernel(Queues[I], Device, Kernel, &Args,
- sizeof(Args), &LaunchArgs, &Events[I]));
+ sizeof(Args), &LaunchArgs));
+ ASSERT_SUCCESS(olCreateEvent(Queues[I], &Events[I]));
}
ASSERT_SUCCESS(olSyncEvent(Events[NUM_KERNELS - 1]));
@@ -85,7 +86,8 @@ TEST_P(olWaitEventsTest, SuccessSingleQueue) {
ASSERT_SUCCESS(olWaitEvents(Queue, &Events[I - 1], 1));
ASSERT_SUCCESS(olLaunchKernel(Queue, Device, Kernel, &Args, sizeof(Args),
- &LaunchArgs, &Events[I]));
+ &LaunchArgs));
+ ASSERT_SUCCESS(olCreateEvent(Queue, &Events[I]));
}
ASSERT_SUCCESS(olSyncEvent(Events[NUM_KERNELS - 1]));
@@ -118,7 +120,8 @@ TEST_P(olWaitEventsTest, SuccessMultipleEvents) {
ASSERT_SUCCESS(olWaitEvents(Queues[I], Events, I));
ASSERT_SUCCESS(olLaunchKernel(Queues[I], Device, Kernel, &Args,
- sizeof(Args), &LaunchArgs, &Events[I]));
+ sizeof(Args), &LaunchArgs));
+ ASSERT_SUCCESS(olCreateEvent(Queues[I], &Events[I]));
}
ASSERT_SUCCESS(olSyncEvent(Events[NUM_KERNELS - 1]));
``````````
</details>
https://github.com/llvm/llvm-project/pull/150465
More information about the llvm-commits
mailing list