[llvm] [Offload] Fix olWaitEvents tests after change to events API (PR #150465)

Callum Fare via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 24 10:06:02 PDT 2025


https://github.com/callumfare created https://github.com/llvm/llvm-project/pull/150465

Fix the olWaitEvents tests after #150217 broke them

>From 7d5331d064a66720b6c348d2fbfdabcb1fe20d29 Mon Sep 17 00:00:00 2001
From: Callum Fare <callum at codeplay.com>
Date: Thu, 24 Jul 2025 18:04:24 +0100
Subject: [PATCH] [Offload] Fix olWaitEvents tests after change to events API

---
 offload/unittests/OffloadAPI/queue/olWaitEvents.cpp | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/offload/unittests/OffloadAPI/queue/olWaitEvents.cpp b/offload/unittests/OffloadAPI/queue/olWaitEvents.cpp
index c1e9acd1797d8..9838562752cc4 100644
--- a/offload/unittests/OffloadAPI/queue/olWaitEvents.cpp
+++ b/offload/unittests/OffloadAPI/queue/olWaitEvents.cpp
@@ -52,7 +52,8 @@ TEST_P(olWaitEventsTest, Success) {
       ASSERT_SUCCESS(olWaitEvents(Queues[I], &Events[I - 1], 1));
 
     ASSERT_SUCCESS(olLaunchKernel(Queues[I], Device, Kernel, &Args,
-                                  sizeof(Args), &LaunchArgs, &Events[I]));
+                                  sizeof(Args), &LaunchArgs));
+    ASSERT_SUCCESS(olCreateEvent(Queues[I], &Events[I]));
   }
 
   ASSERT_SUCCESS(olSyncEvent(Events[NUM_KERNELS - 1]));
@@ -85,7 +86,8 @@ TEST_P(olWaitEventsTest, SuccessSingleQueue) {
       ASSERT_SUCCESS(olWaitEvents(Queue, &Events[I - 1], 1));
 
     ASSERT_SUCCESS(olLaunchKernel(Queue, Device, Kernel, &Args, sizeof(Args),
-                                  &LaunchArgs, &Events[I]));
+                                  &LaunchArgs));
+    ASSERT_SUCCESS(olCreateEvent(Queue, &Events[I]));
   }
 
   ASSERT_SUCCESS(olSyncEvent(Events[NUM_KERNELS - 1]));
@@ -118,7 +120,8 @@ TEST_P(olWaitEventsTest, SuccessMultipleEvents) {
       ASSERT_SUCCESS(olWaitEvents(Queues[I], Events, I));
 
     ASSERT_SUCCESS(olLaunchKernel(Queues[I], Device, Kernel, &Args,
-                                  sizeof(Args), &LaunchArgs, &Events[I]));
+                                  sizeof(Args), &LaunchArgs));
+    ASSERT_SUCCESS(olCreateEvent(Queues[I], &Events[I]));
   }
 
   ASSERT_SUCCESS(olSyncEvent(Events[NUM_KERNELS - 1]));



More information about the llvm-commits mailing list