[llvm] [llvm-pdbutil] Pass filename when formatting `setfile` annotation (PR #149705)

via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 20 05:11:41 PDT 2025


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-debuginfo

Author: nerix (Nerixyz)

<details>
<summary>Changes</summary>

When dumping a PDB with an inlinesite that had a ChangeFile annotation, the `Filename` wasn't passed to the format string. This hit an assertion in debug mode and silently failed in release mode.

---
Full diff: https://github.com/llvm/llvm-project/pull/149705.diff


1 Files Affected:

- (modified) llvm/tools/llvm-pdbutil/MinimalSymbolDumper.cpp (+1-1) 


``````````diff
diff --git a/llvm/tools/llvm-pdbutil/MinimalSymbolDumper.cpp b/llvm/tools/llvm-pdbutil/MinimalSymbolDumper.cpp
index 66a091f50d6b2..caed429f8bc4f 100644
--- a/llvm/tools/llvm-pdbutil/MinimalSymbolDumper.cpp
+++ b/llvm/tools/llvm-pdbutil/MinimalSymbolDumper.cpp
@@ -773,7 +773,7 @@ Error MinimalSymbolDumper::visitKnownRecord(CVSymbol &CVR, InlineSiteSym &IS) {
         else
           return MaybeFile.takeError();
       }
-      P.format(" setfile {0} 0x{1}", utohexstr(FileOffset));
+      P.format(" setfile {0} 0x{1}", Filename, utohexstr(FileOffset));
       break;
     }
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/149705


More information about the llvm-commits mailing list