[llvm] [llvm-pdbutil] Pass filename when formatting `setfile` annotation (PR #149705)
via llvm-commits
llvm-commits at lists.llvm.org
Sun Jul 20 05:11:13 PDT 2025
https://github.com/Nerixyz created https://github.com/llvm/llvm-project/pull/149705
When dumping a PDB with an inlinesite that had a ChangeFile annotation, the `Filename` wasn't passed to the format string. This hit an assertion in debug mode and silently failed in release mode.
>From 8b0239fe96870417416389ca9e8342c870061c8d Mon Sep 17 00:00:00 2001
From: Nerixyz <nerixdev at outlook.de>
Date: Sun, 20 Jul 2025 14:06:53 +0200
Subject: [PATCH] [llvm-pdbutil] Pass filename when formatting `setfile`
annotation
---
llvm/tools/llvm-pdbutil/MinimalSymbolDumper.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/llvm/tools/llvm-pdbutil/MinimalSymbolDumper.cpp b/llvm/tools/llvm-pdbutil/MinimalSymbolDumper.cpp
index 66a091f50d6b2..caed429f8bc4f 100644
--- a/llvm/tools/llvm-pdbutil/MinimalSymbolDumper.cpp
+++ b/llvm/tools/llvm-pdbutil/MinimalSymbolDumper.cpp
@@ -773,7 +773,7 @@ Error MinimalSymbolDumper::visitKnownRecord(CVSymbol &CVR, InlineSiteSym &IS) {
else
return MaybeFile.takeError();
}
- P.format(" setfile {0} 0x{1}", utohexstr(FileOffset));
+ P.format(" setfile {0} 0x{1}", Filename, utohexstr(FileOffset));
break;
}
More information about the llvm-commits
mailing list