[llvm] Revert "[Support] Error if SocketPath is too long" (PR #149096)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 16 06:14:55 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-support
Author: Marina Taylor (citymarina)
<details>
<summary>Changes</summary>
Reverts llvm/llvm-project#<!-- -->148903 due to bot failure https://lab.llvm.org/buildbot/#/builders/187/builds/8162
---
Full diff: https://github.com/llvm/llvm-project/pull/149096.diff
1 Files Affected:
- (modified) llvm/lib/Support/raw_socket_stream.cpp (-8)
``````````diff
diff --git a/llvm/lib/Support/raw_socket_stream.cpp b/llvm/lib/Support/raw_socket_stream.cpp
index cf51de889deaf..fd1c681672138 100644
--- a/llvm/lib/Support/raw_socket_stream.cpp
+++ b/llvm/lib/Support/raw_socket_stream.cpp
@@ -119,14 +119,6 @@ ListeningSocket::ListeningSocket(ListeningSocket &&LS)
Expected<ListeningSocket> ListeningSocket::createUnix(StringRef SocketPath,
int MaxBacklog) {
- // If SocketPath is too long, the path will be truncated, and there may be
- // collisions with other truncated addresses that the fs::exists check below
- // will be unable to detect.
- if (SocketPath.size() >= sizeof(sockaddr_un::sun_path))
- return llvm::make_error<StringError>(
- std::make_error_code(std::errc::filename_too_long),
- "SocketPath too long");
-
// Handle instances where the target socket address already exists and
// differentiate between a preexisting file with and without a bound socket
//
``````````
</details>
https://github.com/llvm/llvm-project/pull/149096
More information about the llvm-commits
mailing list