[llvm] Revert "[Support] Error if SocketPath is too long" (PR #149096)

Marina Taylor via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 16 06:14:21 PDT 2025


https://github.com/citymarina created https://github.com/llvm/llvm-project/pull/149096

Reverts llvm/llvm-project#148903 due to bot failure https://lab.llvm.org/buildbot/#/builders/187/builds/8162

>From cc67e3475467dc309b1195bf6cd0c7d9256cfbf2 Mon Sep 17 00:00:00 2001
From: Marina Taylor <marina_taylor at apple.com>
Date: Wed, 16 Jul 2025 14:13:58 +0100
Subject: [PATCH] Revert "[Support] Error if SocketPath is too long (#148903)"

This reverts commit 73630d5e20c8f29aec426954f448079665caf3ab.
---
 llvm/lib/Support/raw_socket_stream.cpp | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/llvm/lib/Support/raw_socket_stream.cpp b/llvm/lib/Support/raw_socket_stream.cpp
index cf51de889deaf..fd1c681672138 100644
--- a/llvm/lib/Support/raw_socket_stream.cpp
+++ b/llvm/lib/Support/raw_socket_stream.cpp
@@ -119,14 +119,6 @@ ListeningSocket::ListeningSocket(ListeningSocket &&LS)
 Expected<ListeningSocket> ListeningSocket::createUnix(StringRef SocketPath,
                                                       int MaxBacklog) {
 
-  // If SocketPath is too long, the path will be truncated, and there may be
-  // collisions with other truncated addresses that the fs::exists check below
-  // will be unable to detect.
-  if (SocketPath.size() >= sizeof(sockaddr_un::sun_path))
-    return llvm::make_error<StringError>(
-        std::make_error_code(std::errc::filename_too_long),
-        "SocketPath too long");
-
   // Handle instances where the target socket address already exists and
   // differentiate between a preexisting file with and without a bound socket
   //



More information about the llvm-commits mailing list