[llvm] [AMDGPU] SelectionDAG divergence tracking should take into account Target divergency. (PR #144947)

Thu Jul 3 09:52:07 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-expensive-checks-ubuntu` running on `as-builder-4` while building `llvm` at step 7 "test-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/187/builds/7663

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 7 (test-check-all) failure: Test just built components: check-all completed (failure)
...
2.923 [10/55/707] Linking CXX executable unittests/Target/X86/X86Tests
2.946 [10/54/708] Linking CXX executable unittests/tools/llvm-profdata/LLVMProfdataTests
3.007 [10/53/709] Linking CXX executable unittests/Transforms/Vectorize/SandboxVectorizer/SandboxVectorizerTests
3.064 [10/52/710] Linking CXX executable unittests/Target/TargetMachineCTests
3.285 [10/51/711] Linking CXX executable unittests/Transforms/Scalar/ScalarTests
3.304 [10/50/712] Linking CXX executable unittests/Transforms/Utils/UtilsTests
3.462 [10/49/713] Linking CXX executable unittests/tools/llvm-mca/LLVMMCATests
3.635 [10/48/714] Linking CXX executable unittests/tools/llvm-exegesis/LLVMExegesisTests
8.568 [10/47/715] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/SchedBoundary.cpp.o
8.748 [10/46/716] Building CXX object unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/AArch64SelectionDAGTest.cpp.o
FAILED: unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/AArch64SelectionDAGTest.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes CCACHE_SLOPPINESS=pch_defines,time_macros /usr/bin/ccache /usr/bin/clang++-21 -DEXPENSIVE_CHECKS -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/worker/as-builder-4/ramdisk/expensive-checks/build/unittests/Target/AArch64 -I/home/buildbot/worker/as-builder-4/ramdisk/expensive-checks/llvm-project/llvm/unittests/Target/AArch64 -I/home/buildbot/worker/as-builder-4/ramdisk/expensive-checks/build/include -I/home/buildbot/worker/as-builder-4/ramdisk/expensive-checks/llvm-project/llvm/include -I/home/buildbot/worker/as-builder-4/ramdisk/expensive-checks/llvm-project/llvm/lib/Target/AArch64 -I/home/buildbot/worker/as-builder-4/ramdisk/expensive-checks/build/lib/Target/AArch64 -I/home/buildbot/worker/as-builder-4/ramdisk/expensive-checks/llvm-project/third-party/unittest/googletest/include -I/home/buildbot/worker/as-builder-4/ramdisk/expensive-checks/llvm-project/third-party/unittest/googlemock/include -U_GLIBCXX_DEBUG -Wno-misleading-indentation -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wno-variadic-macros -Wno-gnu-zero-variadic-macro-arguments -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -Wno-suggest-override -std=c++17 -MD -MT unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/AArch64SelectionDAGTest.cpp.o -MF unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/AArch64SelectionDAGTest.cpp.o.d -o unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/AArch64SelectionDAGTest.cpp.o -c /home/buildbot/worker/as-builder-4/ramdisk/expensive-checks/llvm-project/llvm/unittests/Target/AArch64/AArch64SelectionDAGTest.cpp
/home/buildbot/worker/as-builder-4/ramdisk/expensive-checks/llvm-project/llvm/unittests/Target/AArch64/AArch64SelectionDAGTest.cpp:65:10: error: no matching member function for call to 'init'
   65 |     DAG->init(*MF, ORE, nullptr, nullptr, nullptr, nullptr, nullptr, MMI,
      |     ~~~~~^~~~
/home/buildbot/worker/as-builder-4/ramdisk/expensive-checks/llvm-project/llvm/include/llvm/CodeGen/SelectionDAG.h:472:17: note: candidate function not viable: requires 10 arguments, but 9 were provided
  472 |   LLVM_ABI void init(MachineFunction &NewMF, OptimizationRemarkEmitter &NewORE,
      |                 ^    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  473 |                      Pass *PassPtr, const TargetLibraryInfo *LibraryInfo,
      |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  474 |                      UniformityInfo *UA, ProfileSummaryInfo *PSIin,
      |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  475 |                      BlockFrequencyInfo *BFIin, MachineModuleInfo &MMI,
      |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  476 |                      FunctionVarLocs const *FnVarLocs, bool HasDivergency);
      |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/buildbot/worker/as-builder-4/ramdisk/expensive-checks/llvm-project/llvm/include/llvm/CodeGen/SelectionDAG.h:478:8: note: candidate function not viable: requires 10 arguments, but 9 were provided
  478 |   void init(MachineFunction &NewMF, OptimizationRemarkEmitter &NewORE,
      |        ^    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  479 |             MachineFunctionAnalysisManager &AM,
      |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  480 |             const TargetLibraryInfo *LibraryInfo, UniformityInfo *UA,
      |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  481 |             ProfileSummaryInfo *PSIin, BlockFrequencyInfo *BFIin,
      |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  482 |             MachineModuleInfo &MMI, FunctionVarLocs const *FnVarLocs,
      |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  483 |             bool HasDivergency) {
      |             ~~~~~~~~~~~~~~~~~~
1 error generated.
9.230 [10/45/717] Building CXX object unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/Immediates.cpp.o
9.288 [10/44/718] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/TypeTraitsTest.cpp.o
9.540 [10/43/719] Building CXX object unittests/CodeGen/GlobalISel/CMakeFiles/GlobalISelTests.dir/ConstantFoldingTest.cpp.o
9.542 [10/42/720] Building CXX object unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/MatrixRegisterAliasing.cpp.o
9.626 [10/41/721] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/X86MCInstLowerTest.cpp.o
9.638 [10/40/722] Building CXX object unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/AArch64RegisterInfoTest.cpp.o
9.768 [10/39/723] Building CXX object unittests/CodeGen/GlobalISel/CMakeFiles/GlobalISelTests.dir/GISelAliasTest.cpp.o
9.870 [10/38/724] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/RegAllocScoreTest.cpp.o
9.969 [10/37/725] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/SelectionDAGAddressAnalysisTest.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/144947