[llvm] [AMDGPU] SelectionDAG divergence tracking should take into account Target divergency. (PR #144947)

Thu Jul 3 09:47:40 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-gcc-ubuntu` running on `sie-linux-worker3` while building `llvm` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/174/builds/20463

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
325.272 [97/31/870] Linking CXX executable unittests/tools/llvm-profdata/LLVMProfdataTests
325.315 [97/30/871] Building CXX object unittests/CodeGen/GlobalISel/CMakeFiles/GlobalISelTests.dir/KnownBitsTest.cpp.o
325.599 [97/29/872] Building CXX object unittests/CodeGen/GlobalISel/CMakeFiles/GlobalISelTests.dir/InstructionSelectTest.cpp.o
325.629 [97/28/873] Linking CXX executable unittests/Target/WebAssembly/WebAssemblyTests
325.758 [97/27/874] Building CXX object unittests/CodeGen/GlobalISel/CMakeFiles/GlobalISelTests.dir/PatternMatchTest.cpp.o
325.879 [97/26/875] Linking CXX executable unittests/tools/llvm-cfi-verify/CFIVerifyTests
326.566 [97/25/876] Building CXX object unittests/CodeGen/GlobalISel/CMakeFiles/GlobalISelTests.dir/GISelUtilsTest.cpp.o
326.608 [97/24/877] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/SelectionDAGPatternMatchTest.cpp.o
328.278 [97/23/878] Building CXX object unittests/CodeGen/GlobalISel/CMakeFiles/GlobalISelTests.dir/LegalizerHelperTest.cpp.o
329.936 [97/22/879] Building CXX object unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/AArch64SelectionDAGTest.cpp.o
FAILED: unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/AArch64SelectionDAGTest.cpp.o 
/opt/ccache/bin/g++ -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/unittests/Target/AArch64 -I/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/llvm/unittests/Target/AArch64 -I/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/include -I/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/llvm/include -I/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/llvm/lib/Target/AArch64 -I/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/build/lib/Target/AArch64 -I/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/third-party/unittest/googletest/include -I/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/third-party/unittest/googlemock/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wno-dangling-else -Wno-variadic-macros -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -Wno-suggest-override -std=c++17 -MD -MT unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/AArch64SelectionDAGTest.cpp.o -MF unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/AArch64SelectionDAGTest.cpp.o.d -o unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/AArch64SelectionDAGTest.cpp.o -c /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/llvm/unittests/Target/AArch64/AArch64SelectionDAGTest.cpp
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/llvm/unittests/Target/AArch64/AArch64SelectionDAGTest.cpp: In member function ‘virtual void llvm::AArch64SelectionDAGTest::SetUp()’:
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/llvm/unittests/Target/AArch64/AArch64SelectionDAGTest.cpp:66:22: error: no matching function for call to ‘llvm::SelectionDAG::init(llvm::MachineFunction&, llvm::OptimizationRemarkEmitter&, std::nullptr_t, std::nullptr_t, std::nullptr_t, std::nullptr_t, std::nullptr_t, llvm::MachineModuleInfo&, std::nullptr_t)’
   66 |               nullptr);
      |                      ^
In file included from /home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/llvm/unittests/Target/AArch64/AArch64SelectionDAGTest.cpp:13:
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/llvm/include/llvm/CodeGen/SelectionDAG.h:472:17: note: candidate: ‘void llvm::SelectionDAG::init(llvm::MachineFunction&, llvm::OptimizationRemarkEmitter&, llvm::Pass*, const llvm::TargetLibraryInfo*, llvm::UniformityInfo*, llvm::ProfileSummaryInfo*, llvm::BlockFrequencyInfo*, llvm::MachineModuleInfo&, const llvm::FunctionVarLocs*, bool)’
  472 |   LLVM_ABI void init(MachineFunction &NewMF, OptimizationRemarkEmitter &NewORE,
      |                 ^~~~
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/llvm/include/llvm/CodeGen/SelectionDAG.h:472:17: note:   candidate expects 10 arguments, 9 provided
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/llvm/include/llvm/CodeGen/SelectionDAG.h:478:8: note: candidate: ‘void llvm::SelectionDAG::init(llvm::MachineFunction&, llvm::OptimizationRemarkEmitter&, llvm::MachineFunctionAnalysisManager&, const llvm::TargetLibraryInfo*, llvm::UniformityInfo*, llvm::ProfileSummaryInfo*, llvm::BlockFrequencyInfo*, llvm::MachineModuleInfo&, const llvm::FunctionVarLocs*, bool)’
  478 |   void init(MachineFunction &NewMF, OptimizationRemarkEmitter &NewORE,
      |        ^~~~
/home/buildbot/buildbot-root/llvm-clang-x86_64-gcc-ubuntu/llvm-project/llvm/include/llvm/CodeGen/SelectionDAG.h:478:8: note:   candidate expects 10 arguments, 9 provided
330.408 [97/21/880] Building CXX object unittests/MIR/CMakeFiles/MIRTests.dir/MachineMetadata.cpp.o
330.717 [97/20/881] Building CXX object unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/AddressingModes.cpp.o
331.577 [97/19/882] Building CXX object unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/AArch64RegisterInfoTest.cpp.o
331.650 [97/18/883] Building CXX object unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/AArch64SVESchedPseudoTest.cpp.o
332.224 [97/17/884] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/InstrRefLDVTest.cpp.o
332.484 [97/16/885] Building CXX object unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/MatrixRegisterAliasing.cpp.o
332.548 [97/15/886] Building CXX object unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/Immediates.cpp.o
332.693 [97/14/887] Building CXX object unittests/Target/VE/CMakeFiles/VETests.dir/MachineInstrTest.cpp.o
332.749 [97/13/888] Building CXX object unittests/Target/LoongArch/CMakeFiles/LoongArchTests.dir/InstSizes.cpp.o
332.814 [97/12/889] Building CXX object unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/InstSizes.cpp.o
333.951 [97/11/890] Building CXX object unittests/Target/ARM/CMakeFiles/ARMTests.dir/MachineInstrTest.cpp.o
334.600 [97/10/891] Building CXX object unittests/Target/ARM/CMakeFiles/ARMTests.dir/InstSizes.cpp.o
336.645 [97/9/892] Building CXX object unittests/Target/AMDGPU/CMakeFiles/AMDGPUTests.dir/LiveRegUnits.cpp.o
336.824 [97/8/893] Building CXX object unittests/Target/AMDGPU/CMakeFiles/AMDGPUTests.dir/PALMetadata.cpp.o
336.881 [97/7/894] Building CXX object unittests/Target/AMDGPU/CMakeFiles/AMDGPUTests.dir/DwarfRegMappings.cpp.o
337.465 [97/6/895] Building CXX object unittests/Target/AMDGPU/CMakeFiles/AMDGPUTests.dir/CSETest.cpp.o
337.694 [97/5/896] Building CXX object unittests/Target/AMDGPU/CMakeFiles/AMDGPUTests.dir/ExecMayBeModifiedBeforeAnyUse.cpp.o
338.435 [97/4/897] Building CXX object unittests/Target/RISCV/CMakeFiles/RISCVTests.dir/RISCVInstrInfoTest.cpp.o
338.578 [97/3/898] Building CXX object unittests/Target/AMDGPU/CMakeFiles/AMDGPUTests.dir/AMDGPUUnitTests.cpp.o
353.646 [97/2/899] Building CXX object lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86ISelLowering.cpp.o
365.321 [97/1/900] Building CXX object lib/Passes/CMakeFiles/LLVMPasses.dir/PassBuilder.cpp.o
ninja: build stopped: subcommand failed.

```

</details>

https://github.com/llvm/llvm-project/pull/144947