[lld] [lld][BP] Fix duplicate section size measurment (PR #145384)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 23 11:47:21 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-lld
Author: Ellis Hoag (ellishg)
<details>
<summary>Changes</summary>
Fix size measurements for duplicate sections that was added in https://github.com/llvm/llvm-project/pull/145106.
---
Full diff: https://github.com/llvm/llvm-project/pull/145384.diff
1 Files Affected:
- (modified) lld/include/lld/Common/BPSectionOrdererBase.inc (+2-2)
``````````diff
diff --git a/lld/include/lld/Common/BPSectionOrdererBase.inc b/lld/include/lld/Common/BPSectionOrdererBase.inc
index fbeca187aa76f..00c9dc7159ddd 100644
--- a/lld/include/lld/Common/BPSectionOrdererBase.inc
+++ b/lld/include/lld/Common/BPSectionOrdererBase.inc
@@ -319,7 +319,7 @@ auto BPOrderer<D>::computeOrder(
for (auto dupSecIdx : It->getSecond()) {
const auto *dupIsec = sections[dupSecIdx];
if (orderedSections.insert(dupIsec)) {
- duplicateCodeSize += D::getSize(*isec);
+ duplicateCodeSize += D::getSize(*dupIsec);
++numDuplicateCodeSections;
}
}
@@ -337,7 +337,7 @@ auto BPOrderer<D>::computeOrder(
for (auto dupSecIdx : It->getSecond()) {
const auto *dupIsec = sections[dupSecIdx];
if (orderedSections.insert(dupIsec)) {
- duplicateDataSize += D::getSize(*isec);
+ duplicateDataSize += D::getSize(*dupIsec);
++numDuplicateDataSections;
}
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/145384
More information about the llvm-commits
mailing list