[lld] [lld][BP] Fix duplicate section size measurment (PR #145384)

Ellis Hoag via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 23 11:46:46 PDT 2025


https://github.com/ellishg created https://github.com/llvm/llvm-project/pull/145384

Fix size measurements for duplicate sections that was added in https://github.com/llvm/llvm-project/pull/145106.

>From 2602bfa57e98519790cc18fdd30d37ac0edfde82 Mon Sep 17 00:00:00 2001
From: Ellis Hoag <ellishoag at meta.com>
Date: Mon, 23 Jun 2025 11:43:52 -0700
Subject: [PATCH] [lld][BP] Fix section size measurment

---
 lld/include/lld/Common/BPSectionOrdererBase.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lld/include/lld/Common/BPSectionOrdererBase.inc b/lld/include/lld/Common/BPSectionOrdererBase.inc
index fbeca187aa76f..00c9dc7159ddd 100644
--- a/lld/include/lld/Common/BPSectionOrdererBase.inc
+++ b/lld/include/lld/Common/BPSectionOrdererBase.inc
@@ -319,7 +319,7 @@ auto BPOrderer<D>::computeOrder(
     for (auto dupSecIdx : It->getSecond()) {
       const auto *dupIsec = sections[dupSecIdx];
       if (orderedSections.insert(dupIsec)) {
-        duplicateCodeSize += D::getSize(*isec);
+        duplicateCodeSize += D::getSize(*dupIsec);
         ++numDuplicateCodeSections;
       }
     }
@@ -337,7 +337,7 @@ auto BPOrderer<D>::computeOrder(
     for (auto dupSecIdx : It->getSecond()) {
       const auto *dupIsec = sections[dupSecIdx];
       if (orderedSections.insert(dupIsec)) {
-        duplicateDataSize += D::getSize(*isec);
+        duplicateDataSize += D::getSize(*dupIsec);
         ++numDuplicateDataSections;
       }
     }



More information about the llvm-commits mailing list