[llvm] [AVR] Emit relocation record for local branch (PR #145291)

Ben Shi via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 23 02:40:49 PDT 2025


https://github.com/benshi001 requested changes to this pull request.

Thanks for your patch. But please learn some basic points before committing a functional change.

1. Unit tests are needed to show the impact by the functional change.
2. Run `make check-all` locally to ensure that no other unit tests are impacted.

Unfortunately this change leads the many failures, here is the log on my local CentOS.

```bash
Failed Tests (25):
  LLVM :: CodeGen/AVR/branch-relaxation-long-backward.ll
  LLVM :: CodeGen/AVR/branch-relaxation-long-forward.ll
  LLVM :: CodeGen/AVR/jmp.ll
  LLVM :: MC/AVR/inst-brbc.s
  LLVM :: MC/AVR/inst-brbs.s
  LLVM :: MC/AVR/inst-brcc.s
  LLVM :: MC/AVR/inst-brcs.s
  LLVM :: MC/AVR/inst-breq.s
  LLVM :: MC/AVR/inst-brge.s
  LLVM :: MC/AVR/inst-brhc.s
  LLVM :: MC/AVR/inst-brhs.s
  LLVM :: MC/AVR/inst-brid.s
  LLVM :: MC/AVR/inst-brie.s
  LLVM :: MC/AVR/inst-brlo.s
  LLVM :: MC/AVR/inst-brlt.s
  LLVM :: MC/AVR/inst-brmi.s
  LLVM :: MC/AVR/inst-brne.s
  LLVM :: MC/AVR/inst-brpl.s
  LLVM :: MC/AVR/inst-brsh.s
  LLVM :: MC/AVR/inst-brtc.s
  LLVM :: MC/AVR/inst-brts.s
  LLVM :: MC/AVR/inst-brvc.s
  LLVM :: MC/AVR/inst-brvs.s
  LLVM :: MC/AVR/inst-rcall.s
  LLVM :: MC/AVR/inst-rjmp.s


Testing Time: 89.38s

Total Discovered Tests: 66002
  Skipped          :   372 (0.56%)
  Unsupported      : 31014 (46.99%)
  Passed           : 34518 (52.30%)
  Expectedly Failed:    73 (0.11%)
  Failed           :    25 (0.04%)
make[3]: *** [test/CMakeFiles/check-llvm.dir/build.make:71: test/CMakeFiles/check-llvm] Error 1
make[2]: *** [CMakeFiles/Makefile2:199872: test/CMakeFiles/check-llvm.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:199879: test/CMakeFiles/check-llvm.dir/rule] Error 2
make: *** [Makefile:34184: check-llvm] Error 2
```


https://github.com/llvm/llvm-project/pull/145291


More information about the llvm-commits mailing list