[compiler-rt] [TSan] Fix p == end == ShadowMem::end in ShadowSet (PR #144994)
Thurston Dang via llvm-commits
llvm-commits at lists.llvm.org
Sat Jun 21 00:40:42 PDT 2025
thurstond wrote:
> Since the PR is approved, should I:
>
> 1. Merge this fix now? Or
> 2. Revert the original change first and then re-submit a new PR (and request reviews) as you suggested?
>
> Just want to make sure I'm following the correct procedure. Thanks for your help!
Either is fine, I'll leave it up to your judgment.
Although it is "strongly encouraged" to revert to green, that means it is not *mandatory* to do so. Since you already have this fix-forward prepared (and reviewed), if you are confident this resolves all the issues, then please merge it. If you have any doubts at all that there may be lingering issues, then the revert is preferred (because otherwise there will be two separate patches to revert to get back to green).
Welcome to LLVM, and thanks for your contributions :-)
https://github.com/llvm/llvm-project/pull/144994
More information about the llvm-commits
mailing list