[compiler-rt] [TSan] Fix p == end == ShadowMem::end in ShadowSet (PR #144994)

[Kunqiu Chen via llvm-commits]

Camsyn wrote:

Hi @thurstond ,

Thank you so much for the detailed review, the approval, and especially for the guidance on LLVM's developer policy. **As a new contributor to LLVM, this is incredibly helpful.**

You've made a very good point. I now understand that reverting the breaking change is the preferred way to keep the main branch stable, especially when the fix is not trivial.

FYI, I think this change is more than just a pure fix for that PR. I found that the `ShadowSet` function's requirements for its input were too relaxed. Therefore, I restricted its input and updated all of its callers to adapt to the new rule.

Since the PR is approved, should I:

1. Merge this fix now? Or
2. Revert the original change first and then re-submit a new PR (and request reviews) as you suggested?

Just want to make sure I'm following the correct procedure. Thanks for your help!


https://github.com/llvm/llvm-project/pull/144994