[llvm] [AMDGPU] SelectionDAG divergence tracking should take into account Target divergency. (PR #144947)

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 20 03:25:28 PDT 2025


================
@@ -10929,7 +10931,8 @@ SDNode *SelectionDAG::UpdateNodeOperands(SDNode *N, SDValue Op) {
   // Now we update the operands.
   N->OperandList[0].set(Op);
 
-  updateDivergence(N);
+  if (DivergentTarget)
+    updateDivergence(N);
----------------
jayfoad wrote:

I think I'd prefer putting `if (!DivergentTarget) return` as the first thing inside `updateDivergence`, to keep the call sites as simple as possible.

https://github.com/llvm/llvm-project/pull/144947


More information about the llvm-commits mailing list