[llvm] [HLSL] Add descriptor table metadata parsing (PR #142492)

Justin Bogner via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 19 20:54:19 PDT 2025


================
@@ -241,6 +331,76 @@ static bool verifyRegisterSpace(uint32_t RegisterSpace) {
 
 static bool verifyDescriptorFlag(uint32_t Flags) { return (Flags & ~0xE) == 0; }
 
+static bool verifyRangeType(uint32_t Type) {
+  switch (Type) {
+  case llvm::to_underlying(dxbc::DescriptorRangeType::CBV):
+  case llvm::to_underlying(dxbc::DescriptorRangeType::SRV):
+  case llvm::to_underlying(dxbc::DescriptorRangeType::UAV):
+  case llvm::to_underlying(dxbc::DescriptorRangeType::Sampler):
+    return true;
+  };
+
+  return false;
+}
+
+static bool verifyDescriptorRangeFlag(uint32_t Version, uint32_t Type,
+                                      uint32_t FlagsVal) {
+  using FlagT = dxbc::DescriptorRangeFlag;
+  FlagT Flags = FlagT(FlagsVal);
+
+  const bool IsSampler =
+      (Type == llvm::to_underlying(dxbc::DescriptorRangeType::Sampler));
+
+  if (Version == 1) {
----------------
bogner wrote:

Probably worth a comment.
```suggestion
  if (Version == 1) {
  // Since the metadata is unversioned, we expect to explicitly see the values
  // that map to the version 1 behaviour here.
```


https://github.com/llvm/llvm-project/pull/142492


More information about the llvm-commits mailing list