[llvm] [NFC] Various Cleanup in StackColoring, StackSlotColoring, LiveStacks (PR #143931)

[via llvm-commits]

Ralender wrote:

It seems like there was no consensus to always deleting lifetime annotations in StackColoring. so I removed that commit.

https://github.com/llvm/llvm-project/pull/143931