[llvm] [Matrix] Hoist finalizeLowering into caller. NFC (PR #143038)
Lei Huang via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 18 17:55:14 PDT 2025
lei137 wrote:
> > Hi @jroelofs, This patch broke us downstream. Can you please provide some information as to what the benefits are provided by this change?
>
> The idea for it came from review feedback from @fhahn in [#141869 (comment)](https://github.com/llvm/llvm-project/pull/141869#discussion_r2129177420): we call finalizeLowering in all of the Visit* methods, so it _should_ be NFC to hoist that into the caller. Can you share a small reproducer?
Unfortunately I can't as it touches upon downstream specific code.
https://github.com/llvm/llvm-project/pull/143038
More information about the llvm-commits
mailing list